[GitHub] [incubator-superset] nytai commented on issue #7804: Server side pagination for charts (tables)

[GitBox <gi...@apache.org>]

nytai commented on issue #7804: Server side pagination for charts (tables)
URL: https://github.com/apache/incubator-superset/issues/7804#issuecomment-566930049
 
 
   While adding pagination to the table chart (especially ungrouped ones) should definitely be done, I think the table chart's search functionality would need to hit the backend or be part of the query for this to solve the use case brought up. I'm fairly certain the table charts search is local (ie, it's only searching over the data held in the client). 
   
   Something this issue highlights is that the filter box runs one query to fetch it's data (with an upper limit) and just runs a local search over that data. A much better design would hit the backend while searching to fetch additional rows lost with the initial limit. This could mean a slow search experience, depending on the cardinality/database conditions, so a an option to enable/disable this behavior would probably make sense. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org