[GitHub] trafficserver pull request #1140: TS-5006: Fix CID 1356975

[zwoop <gi...@git.apache.org>]

Github user zwoop commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1140#discussion_r85228363
  
    --- Diff: proxy/http/HttpSM.cc ---
    @@ -3309,7 +3309,7 @@ HttpSM::tunnel_handler_ua(int event, HttpTunnelConsumer *c)
     
         // only external POSTs should be subject to this logic; ruling out internal POSTs here
         bool is_eligible_post_request = (t_state.method == HTTP_WKSIDX_POST);
    -    if (is_eligible_post_request) {
    +    if (is_eligible_post_request && ua_session) {
    --- End diff --
    
    I don't know this code much, but seeing that we don't crash here, presumably ua_session generally is not NULL here. So maybe a better thing is a release assert?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---