You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Jenna Huston <je...@gmail.com> on 2014/10/09 19:20:47 UTC

Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/
-----------------------------------------------------------

Review request for accumulo.


Bugs: ACCUMULO-3177 and ACCUMULO-3178
    https://issues.apache.org/jira/browse/ACCUMULO-3177
    https://issues.apache.org/jira/browse/ACCUMULO-3178


Repository: accumulo


Description
-------

Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.


Diffs
-----

  core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 
  server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java b2341b6 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee 
  server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 4305e71 
  server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
  server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 8d14cad 
  server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 
  server/master/src/main/java/org/apache/accumulo/master/Master.java b435b0f 
  server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc 
  server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 

Diff: https://reviews.apache.org/r/26507/diff/


Testing
-------

New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.


Thanks,

Jenna Huston


Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

Posted by Jenna Huston <je...@gmail.com>.

> On Oct. 13, 2014, 6:05 p.m., Josh Elser wrote:
> > server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java, line 34
> > <https://reviews.apache.org/r/26507/diff/1/?file=716757#file716757line34>
> >
> >     Logging here could get pretty spammy on an active node. We should be able to extrapolate what the chosen volume was when the file actually gets written. Maybe pull them back to trace or just drop.

Yeah just left these and most of the logging in for debugging purposes.  Didn't want to have to put them back in if big changes were needed in this.


> On Oct. 13, 2014, 6:05 p.m., Josh Elser wrote:
> > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java, line 578
> > <https://reviews.apache.org/r/26507/diff/1/?file=716761#file716761line578>
> >
> >     Would be better to just make a VolumeChooserEnvironment that doesn't have any data (to use when !tableId.isPresent()). That collapses this down into the single choose(..) method.

Made the VolumeChooserEnvironment optional and collapsed everything down to the new method.


- Jenna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/#review56419
-----------------------------------------------------------


On Oct. 9, 2014, 5:23 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26507/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 5:23 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3177 and ACCUMULO-3178
>     https://issues.apache.org/jira/browse/ACCUMULO-3177
>     https://issues.apache.org/jira/browse/ACCUMULO-3178
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 
>   server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java b2341b6 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 4305e71 
>   server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
>   server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 8d14cad 
>   server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 
>   server/master/src/main/java/org/apache/accumulo/master/Master.java b435b0f 
>   server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 
> 
> Diff: https://reviews.apache.org/r/26507/diff/
> 
> 
> Testing
> -------
> 
> New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.
> 
> 
> File Attachments
> ----------------
> 
> Diff for 3178
>   https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/#review56419
-----------------------------------------------------------


Noticed some extra things that I didn't on Github. I also tried to not repeat things I had already commented on over there (for both your and my sanity).


server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java
<https://reviews.apache.org/r/26507/#comment96699>

    Why not import HashMap?



server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java
<https://reviews.apache.org/r/26507/#comment96700>

    Include a message that states that the PerTableVolumeChooser failed and that's falling back to random.



server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java
<https://reviews.apache.org/r/26507/#comment96703>

    Logging here could get pretty spammy on an active node. We should be able to extrapolate what the chosen volume was when the file actually gets written. Maybe pull them back to trace or just drop.



server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java
<https://reviews.apache.org/r/26507/#comment96704>

    Keep the original method and add some way for implementations to get a VolumeChooserEnvironment or get rid of the original method. Having both is unnecessary and confusing.



server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java
<https://reviews.apache.org/r/26507/#comment96706>

    Would be better to just make a VolumeChooserEnvironment that doesn't have any data (to use when !tableId.isPresent()). That collapses this down into the single choose(..) method.



server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java
<https://reviews.apache.org/r/26507/#comment96705>

    Needs log message for exception


- Josh Elser


On Oct. 9, 2014, 5:23 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26507/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 5:23 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3177 and ACCUMULO-3178
>     https://issues.apache.org/jira/browse/ACCUMULO-3177
>     https://issues.apache.org/jira/browse/ACCUMULO-3178
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 
>   server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java b2341b6 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 4305e71 
>   server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
>   server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 8d14cad 
>   server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 
>   server/master/src/main/java/org/apache/accumulo/master/Master.java b435b0f 
>   server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 
> 
> Diff: https://reviews.apache.org/r/26507/diff/
> 
> 
> Testing
> -------
> 
> New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.
> 
> 
> File Attachments
> ----------------
> 
> Diff for 3178
>   https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

Posted by Christopher Tubbs <ct...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/#review63922
-----------------------------------------------------------

Ship it!


This patch looks good to me. The latest patch incorporates a patch I provided to Jenna, which makes the PerTableVolumeChooser the default (with the RandomVolumeChooser the default per table), makes the VolumeChooserEnvironment mandatory, and fixes up Initialize to choose without per-table configurations (which do not exist during initialize).

- Christopher Tubbs


On Dec. 4, 2014, 4:54 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26507/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 4:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3177
>     https://issues.apache.org/jira/browse/ACCUMULO-3177
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java c2c3587 
>   server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 37d5088 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 6ebbe1e 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 670c541 
>   server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java aa37e35 
>   server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java dd3355a 
>   server/base/src/main/java/org/apache/accumulo/server/util/RandomizeVolumes.java 82cc855 
>   server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java 2c9fe9c 
>   server/master/src/main/java/org/apache/accumulo/master/Master.java d5d5145 
>   server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 3d39891 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 247645b 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 26a6928 
>   server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java b7d5b0e 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 
>   test/src/main/java/org/apache/accumulo/test/FairVolumeChooser.java 9eb0c84 
> 
> Diff: https://reviews.apache.org/r/26507/diff/
> 
> 
> Testing
> -------
> 
> New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.
> 
> 
> File Attachments
> ----------------
> 
> Diff for 3178
>   https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
> Updated Diff for 3178
>   https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

Posted by Jenna Huston <je...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/
-----------------------------------------------------------

(Updated Dec. 4, 2014, 9:54 p.m.)


Review request for accumulo.


Changes
-------

Squashed in feedback from Christopher.


Bugs: ACCUMULO-3177
    https://issues.apache.org/jira/browse/ACCUMULO-3177


Repository: accumulo


Description
-------

Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/conf/Property.java c2c3587 
  server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 37d5088 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 6ebbe1e 
  server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 670c541 
  server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java aa37e35 
  server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java dd3355a 
  server/base/src/main/java/org/apache/accumulo/server/util/RandomizeVolumes.java 82cc855 
  server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java 2c9fe9c 
  server/master/src/main/java/org/apache/accumulo/master/Master.java d5d5145 
  server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 3d39891 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 247645b 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 26a6928 
  server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java b7d5b0e 
  server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 
  test/src/main/java/org/apache/accumulo/test/FairVolumeChooser.java 9eb0c84 

Diff: https://reviews.apache.org/r/26507/diff/


Testing
-------

New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.


File Attachments
----------------

Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
Updated Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch


Thanks,

Jenna Huston


Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

Posted by Jenna Huston <je...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/
-----------------------------------------------------------

(Updated Nov. 26, 2014, 3:39 p.m.)


Review request for accumulo.


Changes
-------

Small change to PerTableVolumeChooser


Bugs: ACCUMULO-3177
    https://issues.apache.org/jira/browse/ACCUMULO-3177


Repository: accumulo


Description
-------

Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/conf/Property.java 1195668 
  server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 37d5088 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java baad742 
  server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java a15e05e 
  server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java aa37e35 
  server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 97b8cff 
  server/base/src/main/java/org/apache/accumulo/server/util/RandomizeVolumes.java 002659d 
  server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java 2c9fe9c 
  server/master/src/main/java/org/apache/accumulo/master/Master.java 93691fb 
  server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java f5ed941 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 1e4d40e 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 35067ce 
  server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java b7d5b0e 
  server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 
  test/src/main/java/org/apache/accumulo/test/FairVolumeChooser.java 9eb0c84 

Diff: https://reviews.apache.org/r/26507/diff/


Testing
-------

New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.


File Attachments
----------------

Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
Updated Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch


Thanks,

Jenna Huston


Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

Posted by Jenna Huston <je...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/
-----------------------------------------------------------

(Updated Nov. 26, 2014, 2:48 p.m.)


Review request for accumulo.


Changes
-------

Rebased onto the most current form of master.


Bugs: ACCUMULO-3177
    https://issues.apache.org/jira/browse/ACCUMULO-3177


Repository: accumulo


Description
-------

Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/conf/Property.java 1195668 
  server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 37d5088 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java baad742 
  server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java a15e05e 
  server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java aa37e35 
  server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 97b8cff 
  server/base/src/main/java/org/apache/accumulo/server/util/RandomizeVolumes.java 002659d 
  server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java 2c9fe9c 
  server/master/src/main/java/org/apache/accumulo/master/Master.java 93691fb 
  server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java f5ed941 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 1e4d40e 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 35067ce 
  server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java b7d5b0e 
  server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 
  test/src/main/java/org/apache/accumulo/test/FairVolumeChooser.java 9eb0c84 

Diff: https://reviews.apache.org/r/26507/diff/


Testing
-------

New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.


File Attachments
----------------

Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
Updated Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch


Thanks,

Jenna Huston


Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/#review58802
-----------------------------------------------------------

Ship it!


Ship It!

- Josh Elser


On Oct. 28, 2014, 12:48 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26507/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 12:48 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3177
>     https://issues.apache.org/jira/browse/ACCUMULO-3177
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 
>   server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java e4a42dc 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214 
>   server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
>   server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 5f34279 
>   server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 
>   server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4 
>   server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 44ca898 
>   server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 
> 
> Diff: https://reviews.apache.org/r/26507/diff/
> 
> 
> Testing
> -------
> 
> New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.
> 
> 
> File Attachments
> ----------------
> 
> Diff for 3178
>   https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
> Updated Diff for 3178
>   https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

Posted by Jenna Huston <je...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/
-----------------------------------------------------------

(Updated Oct. 28, 2014, 12:48 p.m.)


Review request for accumulo.


Bugs: ACCUMULO-3177
    https://issues.apache.org/jira/browse/ACCUMULO-3177


Repository: accumulo


Description
-------

Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 
  server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java e4a42dc 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee 
  server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214 
  server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
  server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 5f34279 
  server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 
  server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4 
  server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 44ca898 
  server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc 
  server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 

Diff: https://reviews.apache.org/r/26507/diff/


Testing
-------

New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.


File Attachments
----------------

Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
Updated Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch


Thanks,

Jenna Huston


Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/#review58678
-----------------------------------------------------------


This is looking good. One minor nit on the error message.


server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java
<https://reviews.apache.org/r/26507/#comment99761>

    Would be nice to include the actual class name (the implementation) that the user specified in the log message.


- Josh Elser


On Oct. 27, 2014, 8:15 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26507/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 8:15 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3177
>     https://issues.apache.org/jira/browse/ACCUMULO-3177
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 
>   server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java e4a42dc 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214 
>   server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
>   server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 5f34279 
>   server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 
>   server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4 
>   server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 44ca898 
>   server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 
> 
> Diff: https://reviews.apache.org/r/26507/diff/
> 
> 
> Testing
> -------
> 
> New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.
> 
> 
> File Attachments
> ----------------
> 
> Diff for 3178
>   https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
> Updated Diff for 3178
>   https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

Posted by Jenna Huston <je...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/
-----------------------------------------------------------

(Updated Oct. 27, 2014, 8:15 p.m.)


Review request for accumulo.


Bugs: ACCUMULO-3177
    https://issues.apache.org/jira/browse/ACCUMULO-3177


Repository: accumulo


Description
-------

Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.


Diffs
-----

  core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 
  server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java e4a42dc 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee 
  server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214 
  server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
  server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 5f34279 
  server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 
  server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4 
  server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 44ca898 
  server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc 
  server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 

Diff: https://reviews.apache.org/r/26507/diff/


Testing
-------

New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.


File Attachments
----------------

Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
Updated Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch


Thanks,

Jenna Huston


Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

Posted by Jenna Huston <je...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/
-----------------------------------------------------------

(Updated Oct. 27, 2014, 8:13 p.m.)


Review request for accumulo.


Changes
-------

Changed code to not depend on ACCUMULO-3176.  Used namespace properties instead.


Bugs: ACCUMULO-3177 and ACCUMULO-3178
    https://issues.apache.org/jira/browse/ACCUMULO-3177
    https://issues.apache.org/jira/browse/ACCUMULO-3178


Repository: accumulo


Description
-------

Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 
  server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java e4a42dc 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee 
  server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214 
  server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
  server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 5f34279 
  server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 
  server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4 
  server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 44ca898 
  server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc 
  server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 

Diff: https://reviews.apache.org/r/26507/diff/


Testing
-------

New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.


File Attachments
----------------

Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
Updated Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch


Thanks,

Jenna Huston


Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

Posted by Eric Newton <er...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/#review56558
-----------------------------------------------------------

Ship it!


Ship It!

- Eric Newton


On Oct. 14, 2014, 3:51 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26507/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 3:51 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3177 and ACCUMULO-3178
>     https://issues.apache.org/jira/browse/ACCUMULO-3177
>     https://issues.apache.org/jira/browse/ACCUMULO-3178
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 
>   server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java b2341b6 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 4305e71 
>   server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
>   server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 8d14cad 
>   server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 
>   server/master/src/main/java/org/apache/accumulo/master/Master.java b435b0f 
>   server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 
> 
> Diff: https://reviews.apache.org/r/26507/diff/
> 
> 
> Testing
> -------
> 
> New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.
> 
> 
> File Attachments
> ----------------
> 
> Diff for 3178
>   https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
> Updated Diff for 3178
>   https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

Posted by Jenna Huston <je...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/
-----------------------------------------------------------

(Updated Oct. 14, 2014, 3:51 p.m.)


Review request for accumulo.


Bugs: ACCUMULO-3177 and ACCUMULO-3178
    https://issues.apache.org/jira/browse/ACCUMULO-3177
    https://issues.apache.org/jira/browse/ACCUMULO-3178


Repository: accumulo


Description
-------

Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 
  server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java b2341b6 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee 
  server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 4305e71 
  server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
  server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 8d14cad 
  server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 
  server/master/src/main/java/org/apache/accumulo/master/Master.java b435b0f 
  server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc 
  server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 

Diff: https://reviews.apache.org/r/26507/diff/


Testing
-------

New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.


File Attachments (updated)
----------------

Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
Updated Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch


Thanks,

Jenna Huston


Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser

Posted by Jenna Huston <je...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/
-----------------------------------------------------------

(Updated Oct. 9, 2014, 5:23 p.m.)


Review request for accumulo.


Bugs: ACCUMULO-3177 and ACCUMULO-3178
    https://issues.apache.org/jira/browse/ACCUMULO-3177
    https://issues.apache.org/jira/browse/ACCUMULO-3178


Repository: accumulo


Description
-------

Added a per table volume chooser that allows tables to be given a specific volume chooser.  The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table.  When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser.


Diffs
-----

  core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 
  server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java b2341b6 
  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee 
  server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 4305e71 
  server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
  server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 8d14cad 
  server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 
  server/master/src/main/java/org/apache/accumulo/master/Master.java b435b0f 
  server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc 
  server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 

Diff: https://reviews.apache.org/r/26507/diff/


Testing
-------

New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example chooser.


File Attachments (updated)
----------------

Diff for 3178
  https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch


Thanks,

Jenna Huston