[jira] [Commented] (BEAM-1188) More Verifiers For Python E2E Tests

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15799846#comment-15799846 ] 

ASF GitHub Bot commented on BEAM-1188:
--------------------------------------

GitHub user markflyhigh opened a pull request:

    https://github.com/apache/beam/pull/1734

    [BEAM-1188] Accept Multiple Verifiers in One IT

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Each integration test can set multiple verifiers instead of one. This can help users to verify different aspects of pipeline result in one integration test when more verifiers will be provided in `apache_beam.tests.pipeline_verifiers.py`. User can also build own verifiers to meet their needs.
    
    TODO:
    More verifiers are on their way.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markflyhigh/incubator-beam its-accept-multiple-verifiers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1734.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1734
    
----
commit a25c1f4869f9d1add93874070b09cd34be2afbc9
Author: Mark Liu <ma...@google.com>
Date:   2017-01-05T00:18:10Z

    [BEAM-1188] Accept Multiple Verifiers in One IT

----


> More Verifiers For Python E2E Tests
> -----------------------------------
>
>                 Key: BEAM-1188
>                 URL: https://issues.apache.org/jira/browse/BEAM-1188
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-py, testing
>            Reporter: Mark Liu
>            Assignee: Mark Liu
>
> Add more basic verifiers in e2e test to verify output data in different storage/fs:
> 1. File verifier: compute and verify checksum of file(s) that’s stored on a filesystem (GCS / local fs). 
> 2. Bigquery verifier: query from Bigquery table and verify response content. 
> ...
> Also update TestOptions.on_success_matcher to accept a list of matchers instead of single one.
> Note: Have retry when doing IO to avoid test flacky that may come from inconsistency of the filesystem. This problem happened in Java integration tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)