You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Robert Stupp (JIRA)" <ji...@apache.org> on 2015/12/30 16:19:49 UTC

[jira] [Commented] (CASSANDRA-10411) Add/drop multiple columns in one ALTER TABLE statement

    [ https://issues.apache.org/jira/browse/CASSANDRA-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075099#comment-15075099 ] 

Robert Stupp commented on CASSANDRA-10411:
------------------------------------------

[~achowdhe], new features need to go into trunk. Mind to provide a patch against trunk?
Version 2.0 is EOL for while now and won't even get bug fixes. 2.1 is near to EOL and will only get critical bug fixes. 2.2 and 3.0 are "feature complete" and only get bug fixes. So, trunk is the target branch. It is easier to fork the C* repo on github and just provide a link to a "feature branch".

>From a brief view of you patch, it seems that it contains a lot of changes that are just changes to code-style, which makes it hard to see the actual differences (see https://wiki.apache.org/cassandra/HowToContribute for code style and IDE integrations). Please also avoid massive changes to the imports section. You could use a separate unit test and let that class extend {{CQLTester}}. The patch should also take care when the same column name is used multiple times.

Generally, we are moving towards atomic schema changes. So, it would also be ok to go one step further and to allow drops, alters and adds of columns in the same statement like {{ALTER TABLE foo DROP (old_column_one, another_column) ADD (new_column_one bigint, next_column text);}}. Similarly for {{ALTER TYPE}}. Both should take care when touching the same column name in the same statement (drop + add). Mind tackling this, too?

(setting status to "in progress", please set to "patch available", if a new version of the patch is available).

> Add/drop multiple columns in one ALTER TABLE statement
> ------------------------------------------------------
>
>                 Key: CASSANDRA-10411
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10411
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Bryn Cooke
>            Assignee: Amit Singh Chowdhery
>            Priority: Minor
>              Labels: patch
>         Attachments: cassandra-10411.diff
>
>
> Currently it is only possible to add one column at a time in an alter table statement. It would be great if we could add multiple columns at a time.
> The primary reason for this is that adding each column individually seems to take a significant amount of time (at least on my development machine), I know all the columns I want to add, but don't know them until after the initial table is created.
> As a secondary consideration it brings CQL slightly closer to SQL where most databases can handle adding multiple columns in one statement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)