You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/11/07 12:36:01 UTC
[GitHub] [avro] kiyolee opened a new pull request #977: AVRO-2955: Avro-C: Support all Visual Studio versions from 2010 to 2019
kiyolee opened a new pull request #977:
URL: https://github.com/apache/avro/pull/977
AVRO-2955: Avro-C: Support all Visual Studio versions from 2010 to 2019
Fix compiling using Visual Studio 2010|2013|2015|2017|2019.
Fix building using either cmake/ninja or cmake/visualstudio.
Fix testing using cmake/ninja.
Improve Windows compatibility.
All existing tests passed using all Visual Studio versions mentioned.
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-2955
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
*** Imported a couple of files (getopt.h/getopt_long.c) from FreeBSD with modification for Windows. BSD licensed sources should be compatible with the license here.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
*** No new functionality added. All existing tests passed.
### Commits
- [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
*** No new functionality added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] kiyolee commented on pull request #977: AVRO-2955: Avro-C: Support all Visual Studio versions from 2010 to 2019
Posted by GitBox <gi...@apache.org>.
kiyolee commented on pull request #977:
URL: https://github.com/apache/avro/pull/977#issuecomment-1009830931
@martin-g Didn't aware the last pull rebase was messed up. Now fixed.
The following files are originated from FreeBSD and modified to work with MSVC:
- lang/c/src/getopt/getopt.h
- lang/c/src/getopt/getopt_long.c
The license per file does exist and are kept unchanged. What have I missed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #977: AVRO-2955: Avro-C: Support all Visual Studio versions from 2010 to 2019
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #977:
URL: https://github.com/apache/avro/pull/977#issuecomment-1009704236
@kiyolee The PR is messed up somehow. It contains many unrelated commits.
Also the following files have no licence headers:
- lang/c/src/getopt/getopt.h
- lang/c/src/getopt/getopt_long.c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] kiyolee edited a comment on pull request #977: AVRO-2955: Avro-C: Support all Visual Studio versions from 2010 to 2019
Posted by GitBox <gi...@apache.org>.
kiyolee edited a comment on pull request #977:
URL: https://github.com/apache/avro/pull/977#issuecomment-1009830931
@martin-g Didn't aware the last pull rebase was messed up. Now fixed.
The following files are originated from FreeBSD and modified to work with MSVC:
- lang/c/src/getopt/getopt.h
- lang/c/src/getopt/getopt_long.c
The license per file does exist and are kept unchanged. What have I missed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] edited a comment on pull request #977: AVRO-2955: Avro-C: Support all Visual Studio versions from 2010 to 2019
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #977:
URL: https://github.com/apache/avro/pull/977#issuecomment-1036279938
❌ Deploy Preview for *avro-website-preview* failed.
🔨 Explore the source changes: 8c926e11ce9aba5732365b717c5df7f7da41f090
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206759aa1fb7b00077d0121](https://app.netlify.com/sites/avro-website-preview/deploys/6206759aa1fb7b00077d0121)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g commented on pull request #977: AVRO-2955: Avro-C: Support all Visual Studio versions from 2010 to 2019
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #977:
URL: https://github.com/apache/avro/pull/977#issuecomment-1010285477
> The license per file does exist and are kept unchanged. What have I missed?
The RAT test fails because the new files do not have the ASLv2 license.
Since you are copying files from elsewhere we need to add an entry to the NOTICE file about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] netlify[bot] commented on pull request #977: AVRO-2955: Avro-C: Support all Visual Studio versions from 2010 to 2019
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #977:
URL: https://github.com/apache/avro/pull/977#issuecomment-1036279938
👷 Deploy Preview for *avro-website-preview* processing.
🔨 Explore the source changes: 8c926e11ce9aba5732365b717c5df7f7da41f090
🔍 Inspect the deploy log: [https://app.netlify.com/sites/avro-website-preview/deploys/6206759aa1fb7b00077d0121](https://app.netlify.com/sites/avro-website-preview/deploys/6206759aa1fb7b00077d0121)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org