You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/27 02:31:55 UTC

[GitHub] [spark] dongjoon-hyun edited a comment on issue #25587: [SPARK-28877][PYSPARK][test-hadoop3.2][test-java11] Make jaxb-runtime compile-time dependency

dongjoon-hyun edited a comment on issue #25587: [SPARK-28877][PYSPARK][test-hadoop3.2][test-java11] Make jaxb-runtime compile-time dependency
URL: https://github.com/apache/spark/pull/25587#issuecomment-525109713
 
 
   Thank you for review, @srowen . However, our `assembly` jars doesn't have it without this PR, does it? So, this is an issue in not only `test class path`, but also `pre-built artifacts`. Without this PR, the pre-build artifacts will raise the same exception on JDK11. How do you think about that?
   
   **BEFORE THIS PR**
   ```
   $ ls assembly/target/scala-2.12/jars/*runtime*
   assembly/target/scala-2.12/jars/antlr-runtime-3.5.2.jar
   assembly/target/scala-2.12/jars/antlr4-runtime-4.7.1.jar
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org