You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2010/10/28 16:32:57 UTC
svn commit: r1028320 - in
/commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl:
TestGenericKeyedObjectPoolFactory.java TestGenericObjectPoolFactory.java
Author: sebb
Date: Thu Oct 28 14:32:57 2010
New Revision: 1028320
URL: http://svn.apache.org/viewvc?rev=1028320&view=rev
Log:
Avoid boxing warnings by using appropriate assertTrue/assertFalse checks
Modified:
commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericKeyedObjectPoolFactory.java
commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericObjectPoolFactory.java
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericKeyedObjectPoolFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericKeyedObjectPoolFactory.java?rev=1028320&r1=1028319&r2=1028320&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericKeyedObjectPoolFactory.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericKeyedObjectPoolFactory.java Thu Oct 28 14:32:57 2010
@@ -18,6 +18,8 @@
package org.apache.commons.pool2.impl;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
import org.apache.commons.pool2.KeyedObjectPoolFactory;
import org.apache.commons.pool2.KeyedPoolableObjectFactory;
@@ -67,10 +69,10 @@ public class TestGenericKeyedObjectPoolF
assertEquals(4, pool.getMinIdle());
assertEquals(5, pool.getMinEvictableIdleTimeMillis());
assertEquals(6, pool.getNumTestsPerEvictionRun());
- assertEquals(true, pool.getTestOnBorrow());
- assertEquals(false, pool.getTestOnReturn());
- assertEquals(true, pool.getTestWhileIdle());
- assertEquals(false, pool.getLifo());
+ assertTrue(pool.getTestOnBorrow());
+ assertFalse(pool.getTestOnReturn());
+ assertTrue(pool.getTestWhileIdle());
+ assertFalse(pool.getLifo());
assertEquals(8, pool.getTimeBetweenEvictionRunsMillis());
assertEquals(WhenExhaustedAction.GROW, pool.getWhenExhaustedAction());
pool.close();
@@ -106,8 +108,8 @@ public class TestGenericKeyedObjectPoolF
pool = (GenericKeyedObjectPool<Object,Object>)factory.createPool();
assertEquals(1, pool.getMaxActive());
assertEquals(2, pool.getMaxWait());
- assertEquals(true, pool.getTestOnBorrow());
- assertEquals(false, pool.getTestOnReturn());
+ assertTrue(pool.getTestOnBorrow());
+ assertFalse(pool.getTestOnReturn());
assertEquals(WhenExhaustedAction.GROW, pool.getWhenExhaustedAction());
pool.close();
@@ -154,8 +156,8 @@ public class TestGenericKeyedObjectPoolF
assertEquals(1, pool.getMaxActive());
assertEquals(2, pool.getMaxWait());
assertEquals(3, pool.getMaxIdle());
- assertEquals(true, pool.getTestOnBorrow());
- assertEquals(false, pool.getTestOnReturn());
+ assertTrue(pool.getTestOnBorrow());
+ assertFalse(pool.getTestOnReturn());
assertEquals(WhenExhaustedAction.GROW, pool.getWhenExhaustedAction());
pool.close();
@@ -179,9 +181,9 @@ public class TestGenericKeyedObjectPoolF
assertEquals(4, pool.getTimeBetweenEvictionRunsMillis());
assertEquals(5, pool.getNumTestsPerEvictionRun());
assertEquals(6, pool.getMinEvictableIdleTimeMillis());
- assertEquals(true, pool.getTestOnBorrow());
- assertEquals(false, pool.getTestOnReturn());
- assertEquals(false, pool.getTestWhileIdle());
+ assertTrue(pool.getTestOnBorrow());
+ assertFalse(pool.getTestOnReturn());
+ assertFalse(pool.getTestWhileIdle());
assertEquals(WhenExhaustedAction.GROW, pool.getWhenExhaustedAction());
pool.close();
@@ -207,9 +209,9 @@ public class TestGenericKeyedObjectPoolF
assertEquals(5, pool.getTimeBetweenEvictionRunsMillis());
assertEquals(6, pool.getNumTestsPerEvictionRun());
assertEquals(7, pool.getMinEvictableIdleTimeMillis());
- assertEquals(true, pool.getTestOnBorrow());
- assertEquals(false, pool.getTestOnReturn());
- assertEquals(true, pool.getTestWhileIdle());
+ assertTrue(pool.getTestOnBorrow());
+ assertFalse(pool.getTestOnReturn());
+ assertTrue(pool.getTestWhileIdle());
assertEquals(WhenExhaustedAction.GROW, pool.getWhenExhaustedAction());
pool.close();
}
Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericObjectPoolFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericObjectPoolFactory.java?rev=1028320&r1=1028319&r2=1028320&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericObjectPoolFactory.java (original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericObjectPoolFactory.java Thu Oct 28 14:32:57 2010
@@ -18,6 +18,7 @@
package org.apache.commons.pool2.impl;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
@@ -73,10 +74,10 @@ public class TestGenericObjectPoolFactor
assertEquals(5, pool.getMinEvictableIdleTimeMillis());
assertEquals(6, pool.getNumTestsPerEvictionRun());
assertEquals(7, pool.getSoftMinEvictableIdleTimeMillis());
- assertEquals(true, pool.getTestOnBorrow());
- assertEquals(false, pool.getTestOnReturn());
- assertEquals(true, pool.getTestWhileIdle());
- assertEquals(false, pool.getLifo());
+ assertTrue(pool.getTestOnBorrow());
+ assertFalse(pool.getTestOnReturn());
+ assertTrue(pool.getTestWhileIdle());
+ assertFalse(pool.getLifo());
assertEquals(8, pool.getTimeBetweenEvictionRunsMillis());
assertEquals(WhenExhaustedAction.GROW, pool.getWhenExhaustedAction());
pool.borrowObject();
@@ -124,8 +125,8 @@ public class TestGenericObjectPoolFactor
pool = (GenericObjectPool<Object>)factory.createPool();
assertEquals(1, pool.getMaxActive());
assertEquals(2, pool.getMaxWait());
- assertEquals(true, pool.getTestOnBorrow());
- assertEquals(false, pool.getTestOnReturn());
+ assertTrue(pool.getTestOnBorrow());
+ assertFalse(pool.getTestOnReturn());
assertEquals(WhenExhaustedAction.GROW, pool.getWhenExhaustedAction());
pool.borrowObject();
pool.close();
@@ -158,8 +159,8 @@ public class TestGenericObjectPoolFactor
assertEquals(1, pool.getMaxActive());
assertEquals(2, pool.getMaxWait());
assertEquals(3, pool.getMaxIdle());
- assertEquals(true, pool.getTestOnBorrow());
- assertEquals(false, pool.getTestOnReturn());
+ assertTrue(pool.getTestOnBorrow());
+ assertFalse(pool.getTestOnReturn());
assertEquals(WhenExhaustedAction.GROW, pool.getWhenExhaustedAction());
pool.borrowObject();
pool.close();
@@ -184,9 +185,9 @@ public class TestGenericObjectPoolFactor
assertEquals(4, pool.getTimeBetweenEvictionRunsMillis());
assertEquals(5, pool.getNumTestsPerEvictionRun());
assertEquals(6, pool.getMinEvictableIdleTimeMillis());
- assertEquals(true, pool.getTestOnBorrow());
- assertEquals(false, pool.getTestOnReturn());
- assertEquals(false, pool.getTestWhileIdle());
+ assertTrue(pool.getTestOnBorrow());
+ assertFalse(pool.getTestOnReturn());
+ assertFalse(pool.getTestWhileIdle());
assertEquals(WhenExhaustedAction.GROW, pool.getWhenExhaustedAction());
pool.borrowObject();
pool.close();
@@ -213,9 +214,9 @@ public class TestGenericObjectPoolFactor
assertEquals(5, pool.getTimeBetweenEvictionRunsMillis());
assertEquals(6, pool.getNumTestsPerEvictionRun());
assertEquals(7, pool.getMinEvictableIdleTimeMillis());
- assertEquals(true, pool.getTestOnBorrow());
- assertEquals(false, pool.getTestOnReturn());
- assertEquals(true, pool.getTestWhileIdle());
+ assertTrue(pool.getTestOnBorrow());
+ assertFalse(pool.getTestOnReturn());
+ assertTrue(pool.getTestWhileIdle());
assertEquals(WhenExhaustedAction.GROW, pool.getWhenExhaustedAction());
pool.borrowObject();
pool.close();
@@ -245,10 +246,10 @@ public class TestGenericObjectPoolFactor
assertEquals(6, pool.getNumTestsPerEvictionRun());
assertEquals(7, pool.getMinEvictableIdleTimeMillis());
assertEquals(8, pool.getSoftMinEvictableIdleTimeMillis());
- assertEquals(true, pool.getTestOnBorrow());
- assertEquals(false, pool.getTestOnReturn());
- assertEquals(true, pool.getTestWhileIdle());
- assertEquals(false, pool.getLifo());
+ assertTrue(pool.getTestOnBorrow());
+ assertFalse(pool.getTestOnReturn());
+ assertTrue(pool.getTestWhileIdle());
+ assertFalse(pool.getLifo());
assertEquals(WhenExhaustedAction.GROW, pool.getWhenExhaustedAction());
pool.borrowObject();
pool.close();