You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org> on 2023/04/03 13:02:49 UTC
[Impala-ASF-CR] IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19680
Change subject: IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
......................................................................
IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
Change-Id: I0e3fdade3a12570e488a3a58819697134dbb4c15
---
M docs/topics/impala_iceberg.xml
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/19680/1
--
To view, visit http://gerrit.cloudera.org:8080/19680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e3fdade3a12570e488a3a58819697134dbb4c15
Gerrit-Change-Number: 19680
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
[Impala-ASF-CR] IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19680
to look at the new patch set (#2).
Change subject: IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
......................................................................
IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
Change-Id: I0e3fdade3a12570e488a3a58819697134dbb4c15
---
M docs/topics/impala_iceberg.xml
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/19680/2
--
To view, visit http://gerrit.cloudera.org:8080/19680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0e3fdade3a12570e488a3a58819697134dbb4c15
Gerrit-Change-Number: 19680
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19680 )
Change subject: IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/723/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/19680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3fdade3a12570e488a3a58819697134dbb4c15
Gerrit-Change-Number: 19680
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Apr 2023 13:02:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19680 )
Change subject: IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
......................................................................
IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
Change-Id: I0e3fdade3a12570e488a3a58819697134dbb4c15
Reviewed-on: http://gerrit.cloudera.org:8080/19680
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tamas Mate <tm...@apache.org>
---
M docs/topics/impala_iceberg.xml
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tamas Mate: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0e3fdade3a12570e488a3a58819697134dbb4c15
Gerrit-Change-Number: 19680
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19680 )
Change subject: IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/725/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/19680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3fdade3a12570e488a3a58819697134dbb4c15
Gerrit-Change-Number: 19680
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Apr 2023 07:44:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19680 )
Change subject: IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3fdade3a12570e488a3a58819697134dbb4c15
Gerrit-Change-Number: 19680
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 17 Apr 2023 08:26:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19680 )
Change subject: IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19680/1/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/19680/1/docs/topics/impala_iceberg.xml@200
PS1, Line 200: eg.
Nit: e.g.
--
To view, visit http://gerrit.cloudera.org:8080/19680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3fdade3a12570e488a3a58819697134dbb4c15
Gerrit-Change-Number: 19680
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Apr 2023 13:26:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/19680 )
Change subject: IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19680/1/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/19680/1/docs/topics/impala_iceberg.xml@200
PS1, Line 200: e.g
> Nit: e.g.
Done
--
To view, visit http://gerrit.cloudera.org:8080/19680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3fdade3a12570e488a3a58819697134dbb4c15
Gerrit-Change-Number: 19680
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Apr 2023 07:36:20 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/19680 )
Change subject: IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
......................................................................
Patch Set 2:
LGTM! Thank you for updating the Docs as well.
--
To view, visit http://gerrit.cloudera.org:8080/19680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3fdade3a12570e488a3a58819697134dbb4c15
Gerrit-Change-Number: 19680
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Mon, 17 Apr 2023 08:26:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19680 )
Change subject: IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/723/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/19680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3fdade3a12570e488a3a58819697134dbb4c15
Gerrit-Change-Number: 19680
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 03 Apr 2023 13:11:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19680 )
Change subject: IMPALA-11878: Document that AVRO file format is supported in Iceberg tables
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/725/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/19680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e3fdade3a12570e488a3a58819697134dbb4c15
Gerrit-Change-Number: 19680
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Apr 2023 07:35:49 +0000
Gerrit-HasComments: No