[Impala-ASF-CR] IMPALA-14081: Support create/drop paimon table for impala

["Riza Suminto (Code Review)" <ge...@cloudera.org>]

Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22914 )

Change subject: IMPALA-14081: Support create/drop paimon table for impala
......................................................................


Patch Set 9:

(6 comments)

Will do another pass.

http://gerrit.cloudera.org:8080/#/c/22914/6/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/22914/6/bin/impala-config.sh@289
PS6, Line 289: export IMPALA_AIRCOMPRESSOR_VERSIO
> How often we need to change version? I see current released version is actu
Done


http://gerrit.cloudera.org:8080/#/c/22914/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/22914/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@20
PS6, Line 20: import java.util.ArrayDeque;
            : import java.util.ArrayList;
            : import java.util.Arrays;
            : import java.util.Collections;
            : import java.util.Comparator;
            : import java.util.Deque;
            : import java.util.HashMap;
            : import java.util.HashSet;
            : import java.util.IdentityHashMap;
            : import java.util.Iterator;
            : import java.util.LinkedHashMap;
> Please minimize import reordering and keep the old grouping for now.
Done


http://gerrit.cloudera.org:8080/#/c/22914/9/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java
File fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java:

http://gerrit.cloudera.org:8080/#/c/22914/9/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java@83
PS9, Line 83: "org.apache.paimon.hive.PaimonSerDe");
nit: Add comment like others.

  // (paimon)


http://gerrit.cloudera.org:8080/#/c/22914/9/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:

http://gerrit.cloudera.org:8080/#/c/22914/9/fe/src/main/java/org/apache/impala/catalog/Table.java@20
PS9, Line 20: import com.codahale.metrics.Gauge;
            : import com.codahale.metrics.Timer;
            : import com.google.common.base.Preconditions;
            : import com.google.common.collect.Lists;
For existing java files, please maintain the old import order and keep code changes size small.
I understand this is not ideal, but it helps minimizing conflict when we need to create backport.


http://gerrit.cloudera.org:8080/#/c/22914/6/testdata/datasets/functional/functional_schema_template.sql
File testdata/datasets/functional/functional_schema_template.sql:

http://gerrit.cloudera.org:8080/#/c/22914/6/testdata/datasets/functional/functional_schema_template.sql@4800
PS6, Line 4800: hadoop fs -put -f ${IM
> Is the current dataset (testdata/data/paimon_test/paimon_catalog/warehouse/
Done


http://gerrit.cloudera.org:8080/#/c/22914/9/testdata/datasets/functional/functional_schema_template.sql
File testdata/datasets/functional/functional_schema_template.sql:

http://gerrit.cloudera.org:8080/#/c/22914/9/testdata/datasets/functional/functional_schema_template.sql@4798
PS9, Line 4798: ---- DEPENDENT_LOAD
              : `hadoop fs -mkdir -p /test-warehouse/paimon_test/paimon_catalog/warehouse/functional.db && \
              : hadoop fs -put -f ${IMPALA_HOME}/testdata/data/paimon_test/paimon_catalog/warehouse/functional.db/paimon_partitioned /test-warehouse/paimon_test/paimon_catalog/warehouse/functional.db
It looks like Hive can write a Paimon table using a connector
https://paimon.apache.org/docs/master/ecosystem/hive/

Impala minicluster has Hive inside it. If such connector can hook into Hive, you can use DEPENDENT_LOAD_HIVE and run Hive query instead of loading raw files. Have you look into that?



-- 
To view, visit http://gerrit.cloudera.org:8080/22914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57e77f28151e4a91353ef77050f9f0cd7d9d05ef
Gerrit-Change-Number: 22914
Gerrit-PatchSet: 9
Gerrit-Owner: ji chen <ji...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Aug 2025 04:02:04 +0000
Gerrit-HasComments: Yes