You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey A. Ivanov (JIRA)" <ji...@apache.org> on 2006/12/26 13:52:21 UTC
[jira] Created: (HARMONY-2879) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider
field
[classlib][swing] j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider field
----------------------------------------------------------------------------------------------
Key: HARMONY-2879
URL: http://issues.apache.org/jira/browse/HARMONY-2879
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Alexey A. Ivanov
Priority: Minor
javax.swing.plaf.basic.BasicSliderUI has protected slider field. This field is set to the parameter of createXXXListener() method on Harmony, which is not the case with RI.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-2879) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider
field
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey A. Ivanov closed HARMONY-2879.
-------------------------------------
Verified. Thanks.
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider field
> ----------------------------------------------------------------------------------------------
>
> Key: HARMONY-2879
> URL: https://issues.apache.org/jira/browse/HARMONY-2879
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Assigned To: Alexey Petrenko
> Priority: Minor
> Attachments: H2879-BasicSliderUI.patch, H2879-BasicSliderUI.patch, H2879-BasicSliderUITest.patch, H2879-BasicSliderUITest.patch
>
>
> javax.swing.plaf.basic.BasicSliderUI has protected slider field. This field is set to the parameter of createXXXListener() method on Harmony, which is not the case with RI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-2879) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider
field
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Petrenko resolved HARMONY-2879.
--------------------------------------
Resolution: Fixed
The patch has been applied.
Please, verify.
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider field
> ----------------------------------------------------------------------------------------------
>
> Key: HARMONY-2879
> URL: https://issues.apache.org/jira/browse/HARMONY-2879
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Assigned To: Alexey Petrenko
> Priority: Minor
> Attachments: H2879-BasicSliderUI.patch, H2879-BasicSliderUI.patch, H2879-BasicSliderUITest.patch, H2879-BasicSliderUITest.patch
>
>
> javax.swing.plaf.basic.BasicSliderUI has protected slider field. This field is set to the parameter of createXXXListener() method on Harmony, which is not the case with RI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-2879) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider
field
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2879?page=all ]
Alexey A. Ivanov updated HARMONY-2879:
--------------------------------------
Attachment: H2879-BasicSliderUI.patch
The fix makes the updated tests pass on Harmony. (The updated tests pass successfully when run on RI).
I used lazy listener creation where createXXXListener() always returns the same listener instance.
The fix patch incorporates code fixes from HARMONY-2855 and HARMONY-2878.
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider field
> ----------------------------------------------------------------------------------------------
>
> Key: HARMONY-2879
> URL: http://issues.apache.org/jira/browse/HARMONY-2879
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Priority: Minor
> Attachments: H2879-BasicSliderUI.patch, H2879-BasicSliderUITest.patch
>
>
> javax.swing.plaf.basic.BasicSliderUI has protected slider field. This field is set to the parameter of createXXXListener() method on Harmony, which is not the case with RI.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2879) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider
field
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464743 ]
Mark Hindess commented on HARMONY-2879:
---------------------------------------
Alexey, sorry but I've applied the HARMONY-2855 and HARMONY-2878 fixes. Can you update these patches? Thanks.
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider field
> ----------------------------------------------------------------------------------------------
>
> Key: HARMONY-2879
> URL: https://issues.apache.org/jira/browse/HARMONY-2879
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Priority: Minor
> Attachments: H2879-BasicSliderUI.patch, H2879-BasicSliderUITest.patch
>
>
> javax.swing.plaf.basic.BasicSliderUI has protected slider field. This field is set to the parameter of createXXXListener() method on Harmony, which is not the case with RI.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2879) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider
field
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey A. Ivanov updated HARMONY-2879:
--------------------------------------
Attachment: H2879-BasicSliderUITest.patch
H2879-BasicSliderUI.patch
The updated versions of the patches.
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider field
> ----------------------------------------------------------------------------------------------
>
> Key: HARMONY-2879
> URL: https://issues.apache.org/jira/browse/HARMONY-2879
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Assigned To: Alexey Petrenko
> Priority: Minor
> Attachments: H2879-BasicSliderUI.patch, H2879-BasicSliderUI.patch, H2879-BasicSliderUITest.patch, H2879-BasicSliderUITest.patch
>
>
> javax.swing.plaf.basic.BasicSliderUI has protected slider field. This field is set to the parameter of createXXXListener() method on Harmony, which is not the case with RI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-2879) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider
field
Posted by "Alexey A. Ivanov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2879?page=all ]
Alexey A. Ivanov updated HARMONY-2879:
--------------------------------------
Attachment: H2879-BasicSliderUITest.patch
I've updated the test cases to check for these situations.
I've also changed assertFalse(object1 == object2) to assertNotSame().
This patch incorporates test patch from HARMONY-2878.
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider field
> ----------------------------------------------------------------------------------------------
>
> Key: HARMONY-2879
> URL: http://issues.apache.org/jira/browse/HARMONY-2879
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Priority: Minor
> Attachments: H2879-BasicSliderUITest.patch
>
>
> javax.swing.plaf.basic.BasicSliderUI has protected slider field. This field is set to the parameter of createXXXListener() method on Harmony, which is not the case with RI.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-2879) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider
field
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Petrenko reassigned HARMONY-2879:
----------------------------------------
Assignee: Alexey Petrenko
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider field
> ----------------------------------------------------------------------------------------------
>
> Key: HARMONY-2879
> URL: https://issues.apache.org/jira/browse/HARMONY-2879
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Assigned To: Alexey Petrenko
> Priority: Minor
> Attachments: H2879-BasicSliderUI.patch, H2879-BasicSliderUITest.patch
>
>
> javax.swing.plaf.basic.BasicSliderUI has protected slider field. This field is set to the parameter of createXXXListener() method on Harmony, which is not the case with RI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-2879) [classlib][swing]
j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider
field
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12480066 ]
Alexey Petrenko commented on HARMONY-2879:
------------------------------------------
Thanks, Alexey
> [classlib][swing] j.s.plaf.basic.BasicSliderUI.createXXXListener() methods modify slider field
> ----------------------------------------------------------------------------------------------
>
> Key: HARMONY-2879
> URL: https://issues.apache.org/jira/browse/HARMONY-2879
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey A. Ivanov
> Assigned To: Alexey Petrenko
> Priority: Minor
> Attachments: H2879-BasicSliderUI.patch, H2879-BasicSliderUI.patch, H2879-BasicSliderUITest.patch, H2879-BasicSliderUITest.patch
>
>
> javax.swing.plaf.basic.BasicSliderUI has protected slider field. This field is set to the parameter of createXXXListener() method on Harmony, which is not the case with RI.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.