You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "jelmerk (via GitHub)" <gi...@apache.org> on 2023/02/28 13:23:43 UTC
[GitHub] [spark] jelmerk opened a new pull request, #40219: Disable substitution in values
jelmerk opened a new pull request, #40219:
URL: https://github.com/apache/spark/pull/40219
### What changes were proposed in this pull request?
Disable substitution in values for the `StringSubstitutor` used to resolve error messages
An alternative (better)
### Why are the changes needed?
when constructing an error message `ErrorClasssesJSONReader`
1. reads the error message from core/src/main/resources/error/error-classes.json
2. replaces `<fieldValue>` with `${fieldValue}` in the error message it read
3. uses `StringSubstitutor` to replace `${fieldValue}` with the actual value
If `fieldValue` is defined as "${foo}" then it will also try and resolve foo.
When foo is undefined it will throw an IllegalArgumentException
This is very problematic instance in this scenario. Where parsing json will fail if it does not adhere to the correct schema
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40219: Disable substitution in values
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1448329979
When would the field value have a substitution string in it - does this actually happen in practice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1450932083
Hm, no looks like something else is wrong in even setting up the environment. Github issue?
`Error: Error response from daemon: Get "https://ghcr.io/v2/": received unexpected HTTP status: 503 Service Unavailable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1449217153
Oh yeah, won't affect 3.3. A quick test like your proof of concept would be great indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jelmerk commented on pull request #40219: Disable substitution in values
Posted by "jelmerk (via GitHub)" <gi...@apache.org>.
jelmerk commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1448394326
> Sorry I guess I mean I am not clear how this class, which reads error messages, is coming into play here. This is my ignorance. Seems like it wouldn't be related to just parsing user JSON, but the change fixes it?
The example defines `properties` in the schema as a struct but in the json it is a string with the value "${foo}"
An exception is raised during parsing and the message is resolved by that class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40219: Disable substitution in values
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1448413797
Ah, I get it now. I agree with this change for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #40219: [SPARK-42622][CORE] Disable substitution in values
URL: https://github.com/apache/spark/pull/40219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jelmerk commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "jelmerk (via GitHub)" <gi...@apache.org>.
jelmerk commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1448422622
> Edit the title to link it. See other PRs. Minor thing but helps
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1449487177
Wow. Thank you for sharing the details, @jelmerk .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40219: Disable substitution in values
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1448414336
(Can you just file a JIRA and link it per https://spark.apache.org/contributing.html ?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jelmerk commented on pull request #40219: Disable substitution in values
Posted by "jelmerk (via GitHub)" <gi...@apache.org>.
jelmerk commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1448364029
> When would the field value have a substitution string in it - does this actually happen in practice?
I mention one such scenario in my description. Starting from the image on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1449194829
Also, cc @cloud-fan , @MaxGekk , @viirya from SPARK-40530.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1449507636
good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1450161777
Simple is good. Indeed the smallest of changes can even break things. This looks good pending CI/CD tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40219: Disable substitution in values
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1448419107
Edit the title to link it. See other PRs. Minor thing but helps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1449539893
The fix looks okay, but the PR description looks confusing as `What changes were proposed in this pull request?` describes an alternative approach to current `getErrorMessage`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jelmerk commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "jelmerk (via GitHub)" <gi...@apache.org>.
jelmerk commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1449485716
> Oh yeah, won't affect 3.3. A quick test like your proof of concept would be great indeed.
The class itself is not present on 3.3. It is not affected. In-fact thats how we mitigated this problem, that occurred in a production setting for our pipeline. by downgrading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jelmerk commented on pull request #40219: Disable substitution in values
Posted by "jelmerk (via GitHub)" <gi...@apache.org>.
jelmerk commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1448415053
> (Can you just file a JIRA and link it per https://spark.apache.org/contributing.html ?)
Already did that a few mins ago and added it on top of the PR description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jelmerk commented on a diff in pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "jelmerk (via GitHub)" <gi...@apache.org>.
jelmerk commented on code in PR #40219:
URL: https://github.com/apache/spark/pull/40219#discussion_r1121269562
##########
core/src/main/scala/org/apache/spark/ErrorClassesJSONReader.scala:
##########
@@ -47,6 +47,7 @@ class ErrorClassesJsonReader(jsonFileURLs: Seq[URL]) {
val messageTemplate = getMessageTemplate(errorClass)
val sub = new StringSubstitutor(messageParameters.asJava)
sub.setEnableUndefinedVariableException(true)
+ sub.setDisableSubstitutionInValues(true)
Review Comment:
I added a test in SparkThrowableSuite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jelmerk commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "jelmerk (via GitHub)" <gi...@apache.org>.
jelmerk commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1450916393
> Simple is good. Indeed the smallest of changes can even break things. This looks good pending CI/CD tests
I tried triggering it twice but those tests seem unstable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40219: Disable substitution in values
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1448381649
Sorry I guess I mean I am not clear how this class, which reads error messages, is coming into play here. This is my ignorance. Seems like it wouldn't be related to just parsing user JSON, but the change fixes it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sandeep-katta0102 commented on pull request #40219: Disable substitution in values
Posted by "sandeep-katta0102 (via GitHub)" <gi...@apache.org>.
sandeep-katta0102 commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1448306334
@jelmerk could you please raise a bug [here](https://issues.apache.org/jira/projects/SPARK/summary) and use this bug id in the PR for e.g. you can refer the PR https://github.com/apache/spark/pull/40202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1449194251
Since [SPARK-40530](https://issues.apache.org/jira/browse/SPARK-40530) added this, `branch-3.3` seems to be not affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1451982884
Merged to master/3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1449190687
@dongjoon-hyun I'd like a second opinion - should we merge to 3.4 or 3.3? Reasonable fix I think and I'm a little concerned there could be some weird way this would expand some info it shouldn't
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1449193109
For branch-3.4, I'm +1 for backporting.
Does this affect branch-3.3 too, @srowen ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a diff in pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on code in PR #40219:
URL: https://github.com/apache/spark/pull/40219#discussion_r1121033541
##########
core/src/main/scala/org/apache/spark/ErrorClassesJSONReader.scala:
##########
@@ -47,6 +47,7 @@ class ErrorClassesJsonReader(jsonFileURLs: Seq[URL]) {
val messageTemplate = getMessageTemplate(errorClass)
val sub = new StringSubstitutor(messageParameters.asJava)
sub.setEnableUndefinedVariableException(true)
+ sub.setDisableSubstitutionInValues(true)
Review Comment:
Could we add a test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jelmerk commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "jelmerk (via GitHub)" <gi...@apache.org>.
jelmerk commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1449559149
> Please make sure updating the description before merging this.
I removed the alternative solution. Imho It's a much better solution, but if experience has taught me anything getting anything but the smallest of changes merged is an uphill battle so I chose the 1 line fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #40219: [SPARK-42622][CORE] Disable substitution in values
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #40219:
URL: https://github.com/apache/spark/pull/40219#issuecomment-1450918182
Can you re-trigger it again? Although the CI failure looks unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org