You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by Paolo Castagna <ca...@googlemail.com> on 2012/03/22 18:56:23 UTC
Re: svn commit: r809594 [8/9] - in /websites/staging/jena/trunk/content:
./ jena/ jena/about_jena/ jena/documentation/ jena/documentation/assembler/
jena/documentation/inference/ jena/documentation/io/ jena/documentation/javadoc/
jena/documentation/larq/ j...
buildbot@apache.org wrote:
> Modified: websites/staging/jena/trunk/content/jena/documentation/tools/schemagen.html
> ==============================================================================
...
> - <h1 id="quick_links">Quick links</h1>
> + <h1 id="quick-links">Quick links</h1>
...
> -<h1 id="about_jena">About Jena</h1>
> +<h1 id="about-jena">About Jena</h1>
...
This is what I was trying to do:
> -<li><a href="/jena/documentation/larq/index.html">LARQ</a></li>
> +<li><a href="/jena/documentation/larq/index.html">LARQ: Free Text Search</a></li>
But, it had bad consequences... :-/
Sorry, about that (but I think I broke the whole Jena's navigation side bar in staging).
Paolo
Re: svn commit: r809594 [8/9] - in /websites/staging/jena/trunk/content:
./ jena/ jena/about_jena/ jena/documentation/ jena/documentation/assembler/
jena/documentation/inference/ jena/documentation/io/ jena/documentation/javadoc/
jena/documentation/larq/ j...
Posted by Paolo Castagna <ca...@googlemail.com>.
Ian Dickinson wrote:
>> What do you think?
>
> Thanks for looking into this. I've been dealing with some difficult
> family issues, together with heavy day-job project deadlines, so my
> bandwidth for Jena has been rather severely curtailed lately. I'll leave
> it on my todo list to take a look at what you've done, but for now if it
> fixes the presenting problem then that's good enough for me.
Hi Ian
re: family, I did not know, sorry. Forget about Jena website (and don't
ready the following on this email!
Paolo
PS:
For others (or myself in future), in case you need to do something similar
or a similar issue reappears in future.
I think the '_' or '-' appear because of the markdown filter, but we have
no control on it. Therefore we need to adapt and go around the issue via
jena-navigation.js.
Here is how I got around it (it's only a few places in jena-nativation.js...
but not being familiar with it, it took me sometime to find the right ones).
This also taught the lesson that with SVN + buildbots combination changes
are not always reversible.
svn diff -r 1175246:1303991 content/jena/js/jena-navigation.js
Index: content/jena/js/jena-navigation.js
===================================================================
--- content/jena/js/jena-navigation.js (revision 1175246)
+++ content/jena/js/jena-navigation.js (revision 1303991)
@@ -38,7 +38,7 @@
* @param {Object} fn
*/
var findTopMenu = function( fileName, fn ) {
- var expr = (fileName == 'about_jena') ? "#home_menu" : "#topmenu a[href*='"
+ fileName + "']";
+ var expr = (fileName == 'about_jena') ? "#home-menu" : "#topmenu a[href*='"
+ fileName + "']";
$(expr).first().each( function( n ) {
fn( this );
} );
@@ -50,7 +50,7 @@
var getLocation = function() {
var url = checkForDefaultPage();
if (url.match( /\/jena\/index.html$/ )) {
- currentSection.fileName = "about_jena";
+ currentSection.fileName = "about-jena";
currentPage.fileName = "index.html";
}
else {
@@ -89,10 +89,10 @@
var setSideNavigationVisibility = function() {
$("#navigation>h1").hide();
$("#navigation>ul").hide();
- showMenu( "#quick_links" );
- showMenu( "#asf_links" );
+ showMenu( "#quick-links" );
+ showMenu( "#asf-links" );
- var currentTopicMenu = "#" + currentSection.fileName;
+ var currentTopicMenu = "#" + currentSection.fileName.replace( /\_/g, "-" );
showMenu( currentTopicMenu );
// make the current topic link styled as 'current'
Re: svn commit: r809594 [8/9] - in /websites/staging/jena/trunk/content:
./ jena/ jena/about_jena/ jena/documentation/ jena/documentation/assembler/
jena/documentation/inference/ jena/documentation/io/ jena/documentation/javadoc/
jena/documentation/larq/ j...
Posted by Ian Dickinson <ia...@epimorphics.com>.
Hi Paolo,
On 22/03/12 19:17, Paolo Castagna wrote:
> Hi
>
> Ian, please, let me know if the changes in jena-navigation.js to work with '-'
> instead of '_' in the HTML of the navigation bar on the left seem reasonable
> to you.
>
> I think that is a fix to the problem.
>
> I still do not understand how this happened though. My only hypothesis is still
> that somehow the markdown filter behavior has changed.
>
> A further improvement would be to make the jena-navigation.js more robust and
> work with both '-' and '_' in case that changes again.
>
> What do you think?
Thanks for looking into this. I've been dealing with some difficult
family issues, together with heavy day-job project deadlines, so my
bandwidth for Jena has been rather severely curtailed lately. I'll leave
it on my todo list to take a look at what you've done, but for now if it
fixes the presenting problem then that's good enough for me.
Ian
Re: svn commit: r809594 [8/9] - in /websites/staging/jena/trunk/content:
./ jena/ jena/about_jena/ jena/documentation/ jena/documentation/assembler/
jena/documentation/inference/ jena/documentation/io/ jena/documentation/javadoc/
jena/documentation/larq/ j...
Posted by Paolo Castagna <ca...@googlemail.com>.
Hi
Ian, please, let me know if the changes in jena-navigation.js to work with '-'
instead of '_' in the HTML of the navigation bar on the left seem reasonable
to you.
I think that is a fix to the problem.
I still do not understand how this happened though. My only hypothesis is still
that somehow the markdown filter behavior has changed.
A further improvement would be to make the jena-navigation.js more robust and
work with both '-' and '_' in case that changes again.
What do you think?
Paolo
Paolo Castagna wrote:
> buildbot@apache.org wrote:
>> Modified: websites/staging/jena/trunk/content/jena/documentation/tools/schemagen.html
>> ==============================================================================
>
> ...
>> - <h1 id="quick_links">Quick links</h1>
>> + <h1 id="quick-links">Quick links</h1>
> ...
>> -<h1 id="about_jena">About Jena</h1>
>> +<h1 id="about-jena">About Jena</h1>
> ...
>
> This is what I was trying to do:
>> -<li><a href="/jena/documentation/larq/index.html">LARQ</a></li>
>> +<li><a href="/jena/documentation/larq/index.html">LARQ: Free Text Search</a></li>
>
> But, it had bad consequences... :-/
>
> Sorry, about that (but I think I broke the whole Jena's navigation side bar in staging).
>
> Paolo