You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ar...@apache.org on 2026/06/29 23:30:10 UTC

(superset) branch master updated: fix(table): exclude metricSqlExpressions from ownState→extra_form_data spread (#41555)

This is an automated email from the ASF dual-hosted git repository.

Antonio-RiveroMartnez pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 4a32e0b8d13 fix(table): exclude metricSqlExpressions from ownState→extra_form_data spread (#41555)
4a32e0b8d13 is described below

commit 4a32e0b8d1356830940a0624a0013ca2e224f331
Author: Mafi <ma...@gmail.com>
AuthorDate: Tue Jun 30 09:30:03 2026 +1000

    fix(table): exclude metricSqlExpressions from ownState→extra_form_data spread (#41555)
    
    Co-authored-by: Matt Fitzgerald <ma...@preset.io>
    Co-authored-by: Claude Sonnet 4.6 <no...@anthropic.com>
---
 .../src/explore/components/ExploreViewContainer/index.tsx         | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/src/explore/components/ExploreViewContainer/index.tsx b/superset-frontend/src/explore/components/ExploreViewContainer/index.tsx
index caa72a53659..97234fbb114 100644
--- a/superset-frontend/src/explore/components/ExploreViewContainer/index.tsx
+++ b/superset-frontend/src/explore/components/ExploreViewContainer/index.tsx
@@ -1166,8 +1166,12 @@ function mapStateToProps(state: ExploreRootState) {
 
   const slice_id = form_data.slice_id ?? slice?.slice_id ?? 0; // 0 - unsaved chart
 
-  // exclude clientView from extra_form_data; keep other ownState pieces
-  const ownStateForQuery = omit(dataMask[slice_id]?.ownState, ['clientView']);
+  // exclude clientView and metricSqlExpressions from extra_form_data;
+  // metricSqlExpressions is runtime-only and must not be serialised to chart params
+  const ownStateForQuery = omit(dataMask[slice_id]?.ownState, [
+    'clientView',
+    'metricSqlExpressions',
+  ]);
 
   form_data.extra_form_data = mergeExtraFormData(
     { ...form_data.extra_form_data },