You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/04/23 19:48:30 UTC
[jira] Created: (CASSANDRA-97) race condition prevents startup
under Xen vm
race condition prevents startup under Xen vm
--------------------------------------------
Key: CASSANDRA-97
URL: https://issues.apache.org/jira/browse/CASSANDRA-97
Project: Cassandra
Issue Type: Bug
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-97) race condition prevents startup
under Xen vm
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703301#action_12703301 ]
Jonathan Ellis commented on CASSANDRA-97:
-----------------------------------------
here is the thread where the bug was reported: http://groups.google.com/group/cassandra-user/browse_thread/thread/1617bb8fd6e80041/bb3fa9cf12535162
> race condition prevents startup under Xen vm
> --------------------------------------------
>
> Key: CASSANDRA-97
> URL: https://issues.apache.org/jira/browse/CASSANDRA-97
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-r-m-unused-code-do-minor-cleanup.patch, 0002-r-m-unnecessary-race-prone-cancelled-read-write-ke.patch, 0003-renaming-and-final-cleanup.patch, cassandra_race_condition_in_xen.patch
>
>
> Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-97) race condition prevents startup
under Xen vm
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-97:
------------------------------------
Attachment: cassandra_race_condition_in_xen.patch
> race condition prevents startup under Xen vm
> --------------------------------------------
>
> Key: CASSANDRA-97
> URL: https://issues.apache.org/jira/browse/CASSANDRA-97
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-r-m-unused-code-do-minor-cleanup.patch, 0002-r-m-unnecessary-race-prone-cancelled-read-write-ke.patch, 0003-renaming-and-final-cleanup.patch, cassandra_race_condition_in_xen.patch
>
>
> Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-97) race condition prevents startup
under Xen vm
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-97:
------------------------------------
Fix Version/s: 0.3
> race condition prevents startup under Xen vm
> --------------------------------------------
>
> Key: CASSANDRA-97
> URL: https://issues.apache.org/jira/browse/CASSANDRA-97
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-r-m-unused-code-do-minor-cleanup.patch, 0002-r-m-unnecessary-race-prone-cancelled-read-write-ke.patch, 0003-renaming-and-final-cleanup.patch, cassandra_race_condition_in_xen.patch
>
>
> Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-97) race condition prevents startup
under Xen vm
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703425#action_12703425 ]
Eric Evans commented on CASSANDRA-97:
-------------------------------------
First off, I think these patches (000[1-3]) look good. I don't see a reason for the key state collections that currently exist; IMO this is how the code should look, +1 for applying it.
However, I still believe there is a race condition here. Or rather, I am experiencing what seems to be a race condition between the select() call in SelectorManager.run and the invocation of SelectorManager.register() from the main thread.
Is no one else seeing this?
> race condition prevents startup under Xen vm
> --------------------------------------------
>
> Key: CASSANDRA-97
> URL: https://issues.apache.org/jira/browse/CASSANDRA-97
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-r-m-unused-code-do-minor-cleanup.patch, 0002-r-m-unnecessary-race-prone-cancelled-read-write-ke.patch, 0003-renaming-and-final-cleanup.patch, cassandra_race_condition_in_xen.patch
>
>
> Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-97) race condition prevents startup
under Xen vm
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-97:
------------------------------------
Attachment: 0001-r-m-unused-code-do-minor-cleanup.patch
> race condition prevents startup under Xen vm
> --------------------------------------------
>
> Key: CASSANDRA-97
> URL: https://issues.apache.org/jira/browse/CASSANDRA-97
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-r-m-unused-code-do-minor-cleanup.patch
>
>
> Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-97) race condition prevents startup
under Xen vm
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12703840#action_12703840 ]
Eric Evans commented on CASSANDRA-97:
-------------------------------------
+1 for 0004.patch.2, that seems to do the trick.
> race condition prevents startup under Xen vm
> --------------------------------------------
>
> Key: CASSANDRA-97
> URL: https://issues.apache.org/jira/browse/CASSANDRA-97
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-r-m-unused-code-do-minor-cleanup.patch, 0002-r-m-unnecessary-race-prone-cancelled-read-write-ke.patch, 0003-renaming-and-final-cleanup.patch, 0004.patch.2, cassandra_race_condition_in_xen.patch
>
>
> Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-97) race condition prevents startup
under Xen vm
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-97.
-------------------------------------
Resolution: Fixed
committed.
> race condition prevents startup under Xen vm
> --------------------------------------------
>
> Key: CASSANDRA-97
> URL: https://issues.apache.org/jira/browse/CASSANDRA-97
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-r-m-unused-code-do-minor-cleanup.patch, 0002-r-m-unnecessary-race-prone-cancelled-read-write-ke.patch, 0003-renaming-and-final-cleanup.patch, 0004.patch.2, cassandra_race_condition_in_xen.patch
>
>
> Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-97) race condition prevents startup
under Xen vm
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-97:
------------------------------------
Attachment: (was: 0004-start-SelectorManager-after-all-the-selector-registr.patch)
> race condition prevents startup under Xen vm
> --------------------------------------------
>
> Key: CASSANDRA-97
> URL: https://issues.apache.org/jira/browse/CASSANDRA-97
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-r-m-unused-code-do-minor-cleanup.patch, 0002-r-m-unnecessary-race-prone-cancelled-read-write-ke.patch, 0003-renaming-and-final-cleanup.patch, 0004.patch.2, cassandra_race_condition_in_xen.patch
>
>
> Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-97) race condition prevents startup
under Xen vm
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-97:
------------------------------------
Attachment: 0004-start-SelectorManager-after-all-the-selector-registr.patch
committed patches 1-3.
added patch 4: start SelectorManager after all the selector registration is done, to workaround a bug in some linux environments. (Debian etch under vmware player or under EC2 seem to exhibit this problem consistently.) the bug symptom is, the selector register hangs indefinitely even though the select() call is only for 100ms (after which it should stop blocking and let the register through).
> race condition prevents startup under Xen vm
> --------------------------------------------
>
> Key: CASSANDRA-97
> URL: https://issues.apache.org/jira/browse/CASSANDRA-97
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-r-m-unused-code-do-minor-cleanup.patch, 0002-r-m-unnecessary-race-prone-cancelled-read-write-ke.patch, 0003-renaming-and-final-cleanup.patch, 0004-start-SelectorManager-after-all-the-selector-registr.patch, cassandra_race_condition_in_xen.patch
>
>
> Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-97) race condition prevents startup
under Xen vm
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702240#action_12702240 ]
Jonathan Ellis commented on CASSANDRA-97:
-----------------------------------------
The race condition patch is Soo's original one.
But rather than proliferate hacks on top of hacks I think it's best to remove all the unnecessary scaffolding around the Selector entirely.
03
renaming and final cleanup
02
r/m unnecessary & race-prone cancelled/read/write key sets (a main reason to use
select is that select does this for you!)
01
r/m unused code & do minor cleanup
> race condition prevents startup under Xen vm
> --------------------------------------------
>
> Key: CASSANDRA-97
> URL: https://issues.apache.org/jira/browse/CASSANDRA-97
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-r-m-unused-code-do-minor-cleanup.patch, 0002-r-m-unnecessary-race-prone-cancelled-read-write-ke.patch, 0003-renaming-and-final-cleanup.patch, cassandra_race_condition_in_xen.patch
>
>
> Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-97) race condition prevents startup
under Xen vm
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-97:
------------------------------------
Attachment: 0002-r-m-unnecessary-race-prone-cancelled-read-write-ke.patch
> race condition prevents startup under Xen vm
> --------------------------------------------
>
> Key: CASSANDRA-97
> URL: https://issues.apache.org/jira/browse/CASSANDRA-97
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-r-m-unused-code-do-minor-cleanup.patch, 0002-r-m-unnecessary-race-prone-cancelled-read-write-ke.patch, 0003-renaming-and-final-cleanup.patch
>
>
> Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-97) race condition prevents startup
under Xen vm
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-97:
------------------------------------
Attachment: 0003-renaming-and-final-cleanup.patch
> race condition prevents startup under Xen vm
> --------------------------------------------
>
> Key: CASSANDRA-97
> URL: https://issues.apache.org/jira/browse/CASSANDRA-97
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 0001-r-m-unused-code-do-minor-cleanup.patch, 0002-r-m-unnecessary-race-prone-cancelled-read-write-ke.patch, 0003-renaming-and-final-cleanup.patch
>
>
> Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-97) race condition prevents startup
under Xen vm
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-97:
------------------------------------
Attachment: 0004.patch.2
> race condition prevents startup under Xen vm
> --------------------------------------------
>
> Key: CASSANDRA-97
> URL: https://issues.apache.org/jira/browse/CASSANDRA-97
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-r-m-unused-code-do-minor-cleanup.patch, 0002-r-m-unnecessary-race-prone-cancelled-read-write-ke.patch, 0003-renaming-and-final-cleanup.patch, 0004.patch.2, cassandra_race_condition_in_xen.patch
>
>
> Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-97) race condition prevents startup
under Xen vm
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-97:
------------------------------------
Attachment: 0004-start-SelectorManager-after-all-the-selector-registr.patch
oops, needed to rebase post-113.
> race condition prevents startup under Xen vm
> --------------------------------------------
>
> Key: CASSANDRA-97
> URL: https://issues.apache.org/jira/browse/CASSANDRA-97
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-r-m-unused-code-do-minor-cleanup.patch, 0002-r-m-unnecessary-race-prone-cancelled-read-write-ke.patch, 0003-renaming-and-final-cleanup.patch, 0004.patch.2, cassandra_race_condition_in_xen.patch
>
>
> Reported by Soo Hwan Park on the mailing list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.