You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/11/20 17:34:30 UTC
[GitHub] [accumulo] milleruntime opened a new pull request #1799: Add getTabletState to TabletMetadata
milleruntime opened a new pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799
* Dropped LAST column type and included it in LOCATION type so when any
location gets fetched they all do
* Added suspend column to data that gets fetched
* Added testLocationStates() to TabletMetadataTest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#issuecomment-733223855
> ```java
> 2020-11-24T14:18:55,761 [master.Master] DEBUG: [Metadata Tablets] sleeping for 60.00 seconds
> 2020-11-24T14:18:55,762 [master.Master] DEBUG: 3 assigned to dead servers: [1;3;29@(localhost:43027[10003cc6ca20002],null,null), 1;4;3@(localhost:43027[10003cc6ca20002],null,null), 1;5;4@(localhost:43027[10003cc6ca20002],null,null)]...
> 2020-11-24T14:18:55,762 [master.Master] DEBUG: logs for dead servers: {localhost:43027[10003cc6ca20002]=[file:/home/christopher/git/apache/accumulo/accumulo/test/target/mini-tests/org.apache.accumulo.test.master.SuspendedTabletsIT_shutdownAndResumeTserver/accumulo/wal/localhost+43027/cbc1e3e0-31ed-4408-8edc-afc8ec92d178, file:/home/christopher/git/apache/accumulo/accumulo/test/target/mini-tests/org.apache.accumulo.test.master.SuspendedTabletsIT_shutdownAndResumeTserver/accumulo/wal/localhost+43027/ea5759f4-9818-449b-94b6-19d852dc1f6a]}
> 2020-11-24T14:18:55,765 [master.Master] ERROR: Error processing table state for store Normal Tablets
> java.lang.NullPointerException: Cannot invoke "org.apache.accumulo.core.metadata.TServerInstance.getHostAndPort()" because "tls.current" is null
> at org.apache.accumulo.server.master.state.LoggingTabletStateStore.suspend(LoggingTabletStateStore.java:88) ~[accumulo-server-base-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
> at org.apache.accumulo.master.TabletGroupWatcher.handleDeadTablets(TabletGroupWatcher.java:861) ~[accumulo-manager-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
> at org.apache.accumulo.master.TabletGroupWatcher.flushChanges(TabletGroupWatcher.java:911) ~[accumulo-manager-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
> at org.apache.accumulo.master.TabletGroupWatcher.run(TabletGroupWatcher.java:320) [accumulo-manager-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
> ```
This makes me think it may be related to another previous change I made moving `TServerInstance`. I will take a look at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#discussion_r529054827
##########
File path: core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java
##########
@@ -182,6 +183,8 @@ public Options fetch(ColumnType... colsToFetch) {
case SCANS:
families.add(ScanFileColumnFamily.NAME);
break;
+ case SUSPEND:
+ families.add(SuspendLocationColumn.SUSPEND_COLUMN.getColumnFamily());
Review comment:
This needs a break statement to avoid unintentional fall-through:
```suggestion
families.add(SuspendLocationColumn.SUSPEND_COLUMN.getColumnFamily());
break;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#issuecomment-732422732
> No the current code fetches current and future if you specify `ColumnType.LOCATION` as one of the columns to fetch. Instead of adding a new one for suspend and then requiring you to specify 3 different enums to fetch, I made it so `LOCATION` will fetch all 4.
Okay. I was confused. I see where you are adding it to the fetched columns list when this enum is set.
That said, because this would make all 4 columns fetched every time we want to fetch the CURRENT or FUTURE location, it might be better to leave LAST and create a new SUSPEND enum, so that way we only need to fetch the specific locations we need, and no more. It's a little weird that the LOCATION enum fetches both CURRENT and FUTURE locations, but only one should be set anyway, so it's probably fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a change in pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#discussion_r529038737
##########
File path: core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java
##########
@@ -163,15 +163,14 @@ public Options fetch(ColumnType... colsToFetch) {
case FLUSH_ID:
qualifiers.add(FLUSH_COLUMN);
break;
- case LAST:
- families.add(LastLocationColumnFamily.NAME);
- break;
case LOADED:
families.add(BulkFileColumnFamily.NAME);
break;
case LOCATION:
families.add(CurrentLocationColumnFamily.NAME);
families.add(FutureLocationColumnFamily.NAME);
+ families.add(LastLocationColumnFamily.NAME);
+ families.add(TabletsSection.SuspendLocationColumn.SUSPEND_COLUMN.getColumnFamily());
Review comment:
I applied this suggestion manually to the case for SUSPEND.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a change in pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#discussion_r529595252
##########
File path: core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java
##########
@@ -182,6 +183,8 @@ public Options fetch(ColumnType... colsToFetch) {
case SCANS:
families.add(ScanFileColumnFamily.NAME);
break;
+ case SUSPEND:
+ families.add(SuspendLocationColumn.SUSPEND_COLUMN.getColumnFamily());
Review comment:
Thanks good catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#discussion_r528917846
##########
File path: core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletsMetadata.java
##########
@@ -163,15 +163,14 @@ public Options fetch(ColumnType... colsToFetch) {
case FLUSH_ID:
qualifiers.add(FLUSH_COLUMN);
break;
- case LAST:
- families.add(LastLocationColumnFamily.NAME);
- break;
case LOADED:
families.add(BulkFileColumnFamily.NAME);
break;
case LOCATION:
families.add(CurrentLocationColumnFamily.NAME);
families.add(FutureLocationColumnFamily.NAME);
+ families.add(LastLocationColumnFamily.NAME);
+ families.add(TabletsSection.SuspendLocationColumn.SUSPEND_COLUMN.getColumnFamily());
Review comment:
```suggestion
families.add(SuspendLocationColumn.SUSPEND_COLUMN.getColumnFamily());
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#issuecomment-733234808
> This makes me think it may be related to another previous change I made moving `TServerInstance`. I will take a look at it.
That makes more sense. I've created an issue: #1806 to track this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#discussion_r528895990
##########
File path: core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
##########
@@ -98,11 +104,10 @@
}
public enum ColumnType {
- LOCATION,
+ LOCATION, // includes all types in LocationType + SUSPEND
PREV_ROW,
OLD_PREV_ROW,
FILES,
- LAST,
Review comment:
If there's any chance this is serialized, removing the enum changes the ordinals and could break things. Might be safer to mark it as deprecated and add a comment that it is no longer in use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a change in pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#discussion_r528907862
##########
File path: core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
##########
@@ -98,11 +104,10 @@
}
public enum ColumnType {
- LOCATION,
+ LOCATION, // includes all types in LocationType + SUSPEND
PREV_ROW,
OLD_PREV_ROW,
FILES,
- LAST,
Review comment:
I don't think so. This enum is used to tell the class what column families to fetch in the scanner created in `TabletsMetadata`. There is also a check `ensureFetched(ColumnType col)` that is called on the get methods that will throw an error if you didn't fetch the column family associated with that type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a change in pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#discussion_r528922088
##########
File path: core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
##########
@@ -98,11 +104,10 @@
}
public enum ColumnType {
- LOCATION,
+ LOCATION, // includes all types in LocationType + SUSPEND
Review comment:
@ctubbsii I have a comment here. I could rename it to ALL_LOCATIONS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#issuecomment-731349656
This is done but still needs a way to get `Set<TServerInstance> liveTServers`. So once this is merged I can add method to get the set of live tservers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#discussion_r528917223
##########
File path: core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
##########
@@ -98,11 +104,10 @@
}
public enum ColumnType {
- LOCATION,
+ LOCATION, // includes all types in LocationType + SUSPEND
PREV_ROW,
OLD_PREV_ROW,
FILES,
- LAST,
Review comment:
As long as it's just used internally, and never serialized or sent over the wire, it's fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#issuecomment-733210940
@milleruntime This change seems to have caused a regression in the SuspendedTabletsIT test. It seemed to have gotten stuck when I reverted locally, and timed out (but without the following errors), so I can't tell for certain that this PR caused it, but it seems likely related to this PR. Here's the error I'm seeing:
```java
2020-11-24T14:18:55,761 [master.Master] DEBUG: [Metadata Tablets] sleeping for 60.00 seconds
2020-11-24T14:18:55,762 [master.Master] DEBUG: 3 assigned to dead servers: [1;3;29@(localhost:43027[10003cc6ca20002],null,null), 1;4;3@(localhost:43027[10003cc6ca20002],null,null), 1;5;4@(localhost:43027[10003cc6ca20002],null,null)]...
2020-11-24T14:18:55,762 [master.Master] DEBUG: logs for dead servers: {localhost:43027[10003cc6ca20002]=[file:/home/christopher/git/apache/accumulo/accumulo/test/target/mini-tests/org.apache.accumulo.test.master.SuspendedTabletsIT_shutdownAndResumeTserver/accumulo/wal/localhost+43027/cbc1e3e0-31ed-4408-8edc-afc8ec92d178, file:/home/christopher/git/apache/accumulo/accumulo/test/target/mini-tests/org.apache.accumulo.test.master.SuspendedTabletsIT_shutdownAndResumeTserver/accumulo/wal/localhost+43027/ea5759f4-9818-449b-94b6-19d852dc1f6a]}
2020-11-24T14:18:55,765 [master.Master] ERROR: Error processing table state for store Normal Tablets
java.lang.NullPointerException: Cannot invoke "org.apache.accumulo.core.metadata.TServerInstance.getHostAndPort()" because "tls.current" is null
at org.apache.accumulo.server.master.state.LoggingTabletStateStore.suspend(LoggingTabletStateStore.java:88) ~[accumulo-server-base-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at org.apache.accumulo.master.TabletGroupWatcher.handleDeadTablets(TabletGroupWatcher.java:861) ~[accumulo-manager-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at org.apache.accumulo.master.TabletGroupWatcher.flushChanges(TabletGroupWatcher.java:911) ~[accumulo-manager-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
at org.apache.accumulo.master.TabletGroupWatcher.run(TabletGroupWatcher.java:320) [accumulo-manager-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#issuecomment-732349773
> This change is motivated by discussion on #1317 . I added this method to Ample to get the tablet state. The class where this is done is `TabletLocationState` and requires multiple column families (current, future, last and suspend), all having to do with tablet location. To make it easier to do this in Ample, I made the `ColumnType.LOCATION` fetch all four because it seemed confusing to fetch the famillies individually when they are all related.
So, we're already fetching all four column families every time we need a location anyway? The code with the enums kinda seemed to be trying to match up with ensuring the fetching of their respective column families, but your changes removes that matching. It's probably better your way, but I recommend adding a comment to the ensureFetched method (or the enum) to make it clear that when that enum is used, *all* column families for the various locations are fetched.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#discussion_r528918853
##########
File path: core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
##########
@@ -190,10 +195,15 @@ public boolean hasCurrent() {
}
public Location getLast() {
- ensureFetched(ColumnType.LAST);
+ ensureFetched(ColumnType.LOCATION);
Review comment:
This still looks like it's fetching the "loc" column. It might be more clear if this enum that refers to fetching all locations, was something like `ALL_LOCATIONS`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#issuecomment-733222827
> @milleruntime This change seems to have caused a regression in the SuspendedTabletsIT test.
Strange since the only place that we are calling the new code is the new test I added. I haven't even tried using it anywhere yet... yikes!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#issuecomment-732344630
> I'm a little confused by these changes. Are you trying to change the metadata schema to put all the locations in the same column family? I ask because this seems to ensure that the "location" column family is fetched when we're loading the "last" location... and that doesn't make sense to me, because they are in separate column families today. Same with suspend.
This change is motivated by discussion on #1317 . I added this method to Ample to get the tablet state. The class where this is done is `TabletLocationState` and requires multiple column families (current, future, last and suspend), all having to do with tablet location. To make it easier to do this in Ample, I made the `ColumnType.LOCATION` fetch all four because it seemed confusing to fetch the famillies individually when they are all related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a change in pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#discussion_r528932710
##########
File path: core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java
##########
@@ -190,10 +195,15 @@ public boolean hasCurrent() {
}
public Location getLast() {
- ensureFetched(ColumnType.LAST);
+ ensureFetched(ColumnType.LOCATION);
Review comment:
One of the issues is that there is a separate enum called `LocationType` that is used in the inner class `Location` to differentiate between the types. This doesn't really work with `SuspendingTServer` because it is its own special type. I made an attempt to have `SuspendingTServer` extend the `Location` or `TServerInstance` types but it stores the suspension time with the host and port string in Value, differently from how we typically store the tserver host and port with the zk session id.
https://github.com/apache/accumulo/blob/cccac86255cd2d0ecd49e791162ca5cdf07512b6/core/src/main/java/org/apache/accumulo/core/metadata/SuspendingTServer.java#L45
Then this is how TServerInstance is written:
https://github.com/apache/accumulo/blob/cccac86255cd2d0ecd49e791162ca5cdf07512b6/server/base/src/main/java/org/apache/accumulo/server/metadata/TabletMutatorBase.java#L144-L147
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#issuecomment-732357825
> So, we're already fetching all four column families every time we need a location anyway?
No the current code fetches current and future if you specify `ColumnType.LOCATION` as one of the columns to fetch. Instead of adding a new one for suspend and then requiring you to specify 3 different enums to fetch, I made it so `LOCATION` will fetch all 4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime merged pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
milleruntime merged pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #1799: Add getTabletState to TabletMetadata
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1799:
URL: https://github.com/apache/accumulo/pull/1799#issuecomment-732423934
> That said, because this would make all 4 columns fetched every time we want to fetch the CURRENT or FUTURE location, it might be better to leave LAST and create a new SUSPEND enum, so that way we only need to fetch the specific locations we need, and no more. It's a little weird that the LOCATION enum fetches both CURRENT and FUTURE locations, but only one should be set anyway, so it's probably fine.
I realize now that LOCATION will only ever return one value from the two fetched columns (current or future). So I agree, it would be better to keep it that way and add a new type for SUSPEND.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org