[GitHub] [incubator-druid] viongpanzi commented on a change in pull request #7716: Fix memory problem (OOM/FGC) when expression is used in metricsSpec

[GitBox <gi...@apache.org>]

viongpanzi commented on a change in pull request #7716: Fix memory problem (OOM/FGC) when expression is used in metricsSpec
URL: https://github.com/apache/incubator-druid/pull/7716#discussion_r287784384
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/aggregation/AggregatorUtil.java
 ##########
 @@ -196,7 +246,7 @@ static BaseFloatColumnValueSelector makeColumnValueSelectorWithFloatDefault(
     if (fieldName != null) {
       return metricFactory.makeColumnValueSelector(fieldName);
     } else {
-      final Expr expr = Parser.parse(fieldExpression, macroTable);
+      final Expr expr = parseIfAbsent(fieldExpression, macroTable);
 
 Review comment:
   @himanshug sorry for the delayed update! Can you review this patch again?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org