You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by guozhangwang <gi...@git.apache.org> on 2017/01/25 00:14:49 UTC
[GitHub] kafka pull request #2432: KAFKA-3502: KStreamTestDriver needs to be closed a...
GitHub user guozhangwang opened a pull request:
https://github.com/apache/kafka/pull/2432
KAFKA-3502: KStreamTestDriver needs to be closed after the test case
Found a few recently added unit tests did not close KStreamTestDriver after the test itself is closed; this can cause RocksDB virtual function called if the contained topology has some persistent store since they will be initialized but not closed in time.
MINOR fix: found that when closing KStreamTestDriver, we need to first flushing all stores before closing any of them; this is triggered from the `KTableKTableLeftJoin.shouldNotThrowIllegalStateExceptionWhenMultiCacheEvictions`.
MINOR fix: in CachingXXXStore, the `name` field is actually used as the cache's namespace, not really the store name or its corresponding topic name. Fixed it by renaming it to `cacheName` and use `this.name()` elsewhere which will call the underlying store's name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guozhangwang/kafka K3502-kstream-builder-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2432.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2432
----
commit 583975e5f7f17e11e8be87b5c7ec8b0007b79904
Author: Guozhang Wang <wa...@gmail.com>
Date: 2017-01-24T23:35:42Z
make sure KStreamTestDriver is closed upon completing a test
commit 8bff1e1c2241af49c00870226697f7e01783e23d
Author: Guozhang Wang <wa...@gmail.com>
Date: 2017-01-24T23:40:13Z
found another issue with closing / flushing state stores
commit d4eb5d96251a72171eb0b9e4e59f76d9c3c67190
Author: Guozhang Wang <wa...@gmail.com>
Date: 2017-01-25T00:02:36Z
fix unit tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #2432: KAFKA-3502: KStreamTestDriver needs to be closed a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/2432
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---