You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Filip Maj (JIRA)" <ji...@apache.org> on 2012/07/06 18:10:35 UTC
[jira] [Created] (CB-1013) Refactor all platform's device plugin
into a common device plugin
Filip Maj created CB-1013:
-----------------------------
Summary: Refactor all platform's device plugin into a common device plugin
Key: CB-1013
URL: https://issues.apache.org/jira/browse/CB-1013
Project: Apache Cordova
Issue Type: Improvement
Components: Android, Bada, BlackBerry, CordovaJS, iOS, WP7
Affects Versions: 1.9.0
Reporter: Filip Maj
Assignee: Filip Maj
Fix For: 2.0.0
Almost all of the implementations' device plugin does the same thing:
1. On construction, attach to the CordovaReady internal event
2. Inside this event, fire off {{exec}} to a "device" service requesting the "getDeviceInfo" action
3. When that info becomes available, assign the device information to the device plugin properties and fire off the {{CordovaInfoReady}} event.
The one black sheep in this approach is iOS. iOS instead has the native framework directly call the device plugin's {{setInfo}} method (essentially circumventing {{exec}}). This is a problem for emulation layers such as Ripple, where {{exec}} is the abstraction/hook that needs to be utilized.
May need to implement a few platform-specific merge plugins for device, but the core pattern exists in the common one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-1013) Refactor all platform's device plugin
into a common device plugin
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj resolved CB-1013.
---------------------------
Resolution: Fixed
Migration complete!
> Refactor all platform's device plugin into a common device plugin
> -----------------------------------------------------------------
>
> Key: CB-1013
> URL: https://issues.apache.org/jira/browse/CB-1013
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.9.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Fix For: 2.0.0
>
>
> Almost all of the implementations' device plugin does the same thing:
> 1. On construction, attach to the CordovaReady internal event
> 2. Inside this event, fire off {{exec}} to a "device" service requesting the "getDeviceInfo" action
> 3. When that info becomes available, assign the device information to the device plugin properties and fire off the {{CordovaInfoReady}} event.
> The one black sheep in this approach is iOS. iOS instead has the native framework directly call the device plugin's {{setInfo}} method (essentially circumventing {{exec}}). This is a problem for emulation layers such as Ripple, where {{exec}} is the abstraction/hook that needs to be utilized.
> May need to implement a few platform-specific merge plugins for device, but the core pattern exists in the common one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-1013) Refactor all platform's device plugin
into a common device plugin
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj updated CB-1013:
--------------------------
Component/s: (was: Bada)
(was: WP7)
(was: BlackBerry)
(was: Android)
(was: iOS)
> Refactor all platform's device plugin into a common device plugin
> -----------------------------------------------------------------
>
> Key: CB-1013
> URL: https://issues.apache.org/jira/browse/CB-1013
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.9.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Fix For: 2.0.0
>
>
> Almost all of the implementations' device plugin does the same thing:
> 1. On construction, attach to the CordovaReady internal event
> 2. Inside this event, fire off {{exec}} to a "device" service requesting the "getDeviceInfo" action
> 3. When that info becomes available, assign the device information to the device plugin properties and fire off the {{CordovaInfoReady}} event.
> The one black sheep in this approach is iOS. iOS instead has the native framework directly call the device plugin's {{setInfo}} method (essentially circumventing {{exec}}). This is a problem for emulation layers such as Ripple, where {{exec}} is the abstraction/hook that needs to be utilized.
> May need to implement a few platform-specific merge plugins for device, but the core pattern exists in the common one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-1013) Refactor all platform's device plugin
into a common device plugin
Posted by "Filip Maj (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412024#comment-13412024 ]
Filip Maj commented on CB-1013:
-------------------------------
The refactor of the JS is in a branch on Apache here: https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=shortlog;h=refs/heads/device
> Refactor all platform's device plugin into a common device plugin
> -----------------------------------------------------------------
>
> Key: CB-1013
> URL: https://issues.apache.org/jira/browse/CB-1013
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.9.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Fix For: 2.0.0
>
>
> Almost all of the implementations' device plugin does the same thing:
> 1. On construction, attach to the CordovaReady internal event
> 2. Inside this event, fire off {{exec}} to a "device" service requesting the "getDeviceInfo" action
> 3. When that info becomes available, assign the device information to the device plugin properties and fire off the {{CordovaInfoReady}} event.
> The one black sheep in this approach is iOS. iOS instead has the native framework directly call the device plugin's {{setInfo}} method (essentially circumventing {{exec}}). This is a problem for emulation layers such as Ripple, where {{exec}} is the abstraction/hook that needs to be utilized.
> May need to implement a few platform-specific merge plugins for device, but the core pattern exists in the common one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira