[jira] [Commented] (LOG4J2-938) org.apache.logging.log4j.core.jmx.Server never shuts down the ExecutorService it creates

["Mauro Molinari (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345193#comment-14345193 ] 

Mauro Molinari commented on LOG4J2-938:
---------------------------------------

I just verified that in 2.2 the original issue is fixed. Thank you Remko!

> org.apache.logging.log4j.core.jmx.Server never shuts down the ExecutorService it creates
> ----------------------------------------------------------------------------------------
>
>                 Key: LOG4J2-938
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-938
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: JMX
>    Affects Versions: 2.1
>            Reporter: Mauro Molinari
>            Assignee: Remko Popma
>            Priority: Critical
>             Fix For: 2.2
>
>         Attachments: LOG4J2-938.patch
>
>
> The class {{org.apache.logging.log4j.core.jmx.Server}} creates an {{ExecutorService}} at construction time and and stores it as an instance variable of type {{Executor}} (named {{executor}}).
> This executor service is never shut down (I guess the {{unregisterMBeans()}} methods may be good candidates, with some care for {{unregisterMBeans(MBeanServer)}} which performs unregistration only for a single {{MBeanServer}}). This causes a memory leak if Log4j is used in a web application (under Tomcat, for instance) and the JMX services have been used (i.e.: the {{Server}} class has been instantiated).
> But even worse, what I'm observing is that a notification Job may be submitted to that executor by {{javax.management.NotificationBroadcasterSupport.sendNotification(Notification)}}, invoked by {{org.apache.logging.log4j.core.jmx.StatusLoggerAdmin.log(StatusData)}} in certain circumstances exactly during Tomcat shutdown process: since the executor is using non-daemon threads to execute tasks, this eventually prevents the application server to shutdown (I have to kill it).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org