You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "RUSLoker (via GitHub)" <gi...@apache.org> on 2026/01/14 09:13:13 UTC
[PR] Fix error with Boost::headers when building with Thrift [arrow]
RUSLoker opened a new pull request, #48852:
URL: https://github.com/apache/arrow/pull/48852
### Rationale for this change
When I tried to build arrow with bundled Thrift enabled with Boost installed in a system it always fails with an error like following:
```
Building CXX object src/parquet/CMakeFiles/parquet_objlib.dir/bloom_filter.cc.o
FAILED: src/parquet/CMakeFiles/parquet_objlib.dir/bloom_filter.cc.o
/usr/local/bin/c++ -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 -DARROW_WITH_TIMING_TESTS -DHAVE_INTTYPES_H -DHAVE_NETDB_H -DHAVE_NETINET_IN_H -DPARQUET_EXPORTING -DPARQUET_THRIFT_VERSION_MAJOR=0 -DPARQUET_THRIFT_VERSION_MINOR=22 -I/arrow/cpp/build/src -I/arrow/cpp/src -I/arrow/cpp/src/generated -isystem /arrow/cpp/build/xsimd_ep/src/xsimd_ep-install/include -isystem /arrow/cpp/build/rapidjson_ep/src/rapidjson_ep-install/include -isystem /arrow/cpp/build/_deps/thrift-build -isystem /arrow/cpp/build/_deps/thrift-src/lib/cpp/src -Wno-noexcept-type -Wno-self-move -fdiagnostics-color=always -Wall -fno-semantic-interposition -msse4.2 -O3 -O2 -ftree-vectorize -std=c++17 -flto=auto -fno-fat-lto-objects -fPIC -MD -MT src/parquet/CMakeFiles/parquet_objlib.dir/bloom_filter.cc.o -MF src/parquet/CMakeFiles/parquet_objlib.dir/bloom_filter.cc.o.d -o src/parquet/CMakeFiles/parquet_objlib.dir/bloom_filter.cc.
o -c /arrow/cpp/src/parquet/bloom_filter.cc
In file included from /arrow/cpp/build/_deps/thrift-src/lib/cpp/src/thrift/transport/TTransport.h:25,
from /arrow/cpp/build/_deps/thrift-src/lib/cpp/src/thrift/protocol/TProtocol.h:46,
from /arrow/cpp/build/_deps/thrift-src/lib/cpp/src/thrift/TBase.h:24,
from /arrow/cpp/src/generated/parquet_types.h:14,
from /arrow/cpp/src/parquet/bloom_filter.cc:26:
/arrow/cpp/build/_deps/thrift-src/lib/cpp/src/thrift/transport/TTransportException.h:23:10: fatal error: boost/numeric/conversion/cast.hpp: No such file or directory
23 | #include <boost/numeric/conversion/cast.hpp>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
```
As I found out it happens because the `Boost::headers` is not properly linked to the thrift library so it could be linked as a transitive dependency when it's built by the project .
### What changes are included in this PR?
- added the `headers` to the `ARROW_BOOST_COMPONENTS` in `cpp/cmake_modules/ThirdpartyToolchain.cmake`;
- added linking over the `Boost::headers` in the `build_thrift` function in `cpp/cmake_modules/ThirdpartyToolchain.cmake`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix error with Boost::headers when building with Thrift [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48852:
URL: https://github.com/apache/arrow/pull/48852#issuecomment-3748551642
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix error with Boost::headers when building with Thrift [arrow]
Posted by "RUSLoker (via GitHub)" <gi...@apache.org>.
RUSLoker commented on PR #48852:
URL: https://github.com/apache/arrow/pull/48852#issuecomment-3748812781
I have faced this problem when I built 22.0.0. I will try it at the main branch. If there still will be such a problem I will make an issue and pr again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix error with Boost::headers when building with Thrift [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #48852:
URL: https://github.com/apache/arrow/pull/48852#issuecomment-4150428678
Looks like work will be going on in a different PR if needed, so I'll close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix error with Boost::headers when building with Thrift [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic closed pull request #48852: Fix error with Boost::headers when building with Thrift
URL: https://github.com/apache/arrow/pull/48852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org