You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "jacobzheng (GitHub)" <gi...@apache.org> on 2018/10/30 11:48:32 UTC

[GitHub] [incubator-dubbo] jacobzheng opened pull request #2714: Merge pull request #1 from apache/master

Merge pull request

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2714 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] carryxyh closed pull request #2714: Merge pull request #1 from apache/master

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
[ pull request closed by carryxyh ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2714 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org


[GitHub] [incubator-dubbo] codecov-io commented on issue #2714: Merge pull request #1 from apache/master

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2714?src=pr&el=h1) Report
> Merging [#2714](https://codecov.io/gh/apache/incubator-dubbo/pull/2714?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/0a116aa957a81478234076997426cfb6296c2040?src=pr&el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2714/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2714?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #2714      +/-   ##
==========================================
- Coverage    63.5%   62.33%   -1.18%     
==========================================
  Files         580      602      +22     
  Lines       25985    27980    +1995     
  Branches     4544     4832     +288     
==========================================
+ Hits        16503    17440     +937     
- Misses       7314     8263     +949     
- Partials     2168     2277     +109
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2714?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2714/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `41.66% <0%> (-8.34%)` | :arrow_down: |
| [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2714/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `61.17% <0%> (-4.71%)` | :arrow_down: |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2714/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9JbnZva2VUZWxuZXRIYW5kbGVyLmphdmE=) | `54.21% <0%> (-3.62%)` | :arrow_down: |
| [.../rpc/protocol/dubbo/LazyConnectExchangeClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2714/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0xhenlDb25uZWN0RXhjaGFuZ2VDbGllbnQuamF2YQ==) | `55.95% <0%> (-2.39%)` | :arrow_down: |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2714/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `61.17% <0%> (-1.18%)` | :arrow_down: |
| [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2714/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==) | `66.66% <0%> (-0.84%)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2714/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (ø)` | :arrow_up: |
| [...bbo/rpc/protocol/thrift/io/InputStreamWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2714/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90aHJpZnQvaW8vSW5wdXRTdHJlYW1XcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | |
| [...o/rpc/protocol/thrift/DubboClassNameGenerator.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2714/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90aHJpZnQvRHViYm9DbGFzc05hbWVHZW5lcmF0b3IuamF2YQ==) | `100% <0%> (ø)` | |
| [.../java/org/apache/dubbo/common/json/JSONWriter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2714/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vanNvbi9KU09OV3JpdGVyLmphdmE=) | `63.15% <0%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2714/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2714?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2714?src=pr&el=footer). Last update [0a116aa...1431f20](https://codecov.io/gh/apache/incubator-dubbo/pull/2714?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2714 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #2714: Merge pull request #1 from apache/master

Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Nothing changed.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2714 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org