You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "PHILO-HE (via GitHub)" <gi...@apache.org> on 2024/07/31 02:55:51 UTC
[I] [CORE] ParquetFileForamt/OrcFileFormat has code like `if (xxx && false)` [incubator-gluten]
PHILO-HE opened a new issue, #6649:
URL: https://github.com/apache/incubator-gluten/issues/6649
### Description
Not sure why we make this if branch always skipped.
See https://github.com/apache/incubator-gluten/blob/main/shims/spark32/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala#L204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [I] [CORE] ParquetFileForamt/OrcFileFormat has code like `if (xxx && false)` [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on issue #6649:
URL: https://github.com/apache/incubator-gluten/issues/6649#issuecomment-2259562292
Hi @binmahone, do you remember the reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [I] [CORE] ParquetFileForamt/OrcFileFormat has code like `if (xxx && false)` [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on issue #6649:
URL: https://github.com/apache/incubator-gluten/issues/6649#issuecomment-2260565538
> @PHILO-HE does you try if CI pass if remove the false check ?
@gaoyangxiaozhu, thanks for your comment! I will try to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [I] [CORE] ParquetFileForamt/OrcFileFormat has code like `if (xxx && false)` [incubator-gluten]
Posted by "binmahone (via GitHub)" <gi...@apache.org>.
binmahone commented on issue #6649:
URL: https://github.com/apache/incubator-gluten/issues/6649#issuecomment-2268438851
> Hi @binmahone, do you remember the reason?
Sorry I can't really recall. When the intial PR was checked in, velox backend did not actually supported native writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [I] [CORE] ParquetFileForamt/OrcFileFormat has code like `if (xxx && false)` [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on issue #6649:
URL: https://github.com/apache/incubator-gluten/issues/6649#issuecomment-2268446347
> > Hi @binmahone, do you remember the reason?
>
> Sorry I can't really recall. When the intial PR was checked in, velox backend did not actually supported native writer.
@binmahone, I see. Anyway, thanks for your reply!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [I] [CORE] ParquetFileForamt/OrcFileFormat has code like `if (xxx && false)` [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE closed issue #6649: [CORE] ParquetFileForamt/OrcFileFormat has code like `if (xxx && false)`
URL: https://github.com/apache/incubator-gluten/issues/6649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [I] [CORE] ParquetFileForamt/OrcFileFormat has code like `if (xxx && false)` [incubator-gluten]
Posted by "gaoyangxiaozhu (via GitHub)" <gi...@apache.org>.
gaoyangxiaozhu commented on issue #6649:
URL: https://github.com/apache/incubator-gluten/issues/6649#issuecomment-2260312416
@PHILO-HE does you try if CI pass if remove the false check ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [I] [CORE] ParquetFileForamt/OrcFileFormat has code like `if (xxx && false)` [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on issue #6649:
URL: https://github.com/apache/incubator-gluten/issues/6649#issuecomment-2276966833
As confirmed with @JkSelf, we can remove this code to always use vanilla Spark's API for Velox backend. #6663 is removing the useless code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org