[GitHub] [accumulo] keith-turner commented on a diff in pull request #2879: Add new params to import table

[GitBox <gi...@apache.org>]

keith-turner commented on code in PR #2879:
URL: https://github.com/apache/accumulo/pull/2879#discussion_r954949368


##########
core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java:
##########
@@ -192,11 +192,13 @@ default void importTable(String tableName, String importDir)
    *
    * @param tableName
    *          Name of a table to create and import into.
+   * @param ic
+   *          ImportConfiguration for the table being created
    * @param importDirs
    *          A set of directories containing the files copied by distcp from exportTable
    * @since 2.1.0
    */
-  void importTable(String tableName, Set<String> importDirs)
+  void importTable(String tableName, ImportConfiguration ic, Set<String> importDirs)

Review Comment:
   Conceptually ImportConfiguration allows expressing one or more optional arguments.  Could place the two required arguments first and the optional ones last.  This is just personal preference, please ignore if it does not resonate.
   
   ```suggestion
     void importTable(String tableName, Set<String> importDirs, ImportConfiguration ic)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org