You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/11/25 16:26:54 UTC
[GitHub] [activemq-artemis] jbertram commented on a change in pull request
#2901: ARTEMIS-2421 periodic journal lock evaluation
jbertram commented on a change in pull request #2901: ARTEMIS-2421 periodic journal lock evaluation
URL: https://github.com/apache/activemq-artemis/pull/2901#discussion_r350287646
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/FileLockNodeManager.java
##########
@@ -388,4 +404,109 @@ protected FileLock lock(final int lockPosition) throws Exception {
return null;
}
+ private synchronized void startLockMonitoring() {
Review comment:
No, I didn't consider extending `ActiveMQScheduledComponent`. I just took what was on the original PR and cleaned it up so it could actually be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services