You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by ykrips <gi...@git.apache.org> on 2014/10/15 08:56:28 UTC

[GitHub] tajo pull request: TAJO-1109: Separate SQL Statements from Catalog...

GitHub user ykrips opened a pull request:

    https://github.com/apache/tajo/pull/201

    TAJO-1109: Separate SQL Statements from Catalog Stores

    It has been tested on Embedded derby databases, Oracle 11g, and Oracle 12c.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ykrips/tajo TAJO-1109

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/201.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #201
    
----
commit 49e021d9fba48dea73f333b865500e6bfac00e08
Author: Jihun Kang <yk...@gmail.com>
Date:   2014-10-08T15:25:53Z

    TAJO-1093: DateTimeFormat.to_char() is slower than SimpleDateFormat.format()

commit b49688f424d1b0520f01cd3704163108cf294596
Author: Jihun Kang <yk...@gmail.com>
Date:   2014-10-12T05:12:48Z

    Merge remote-tracking branch 'upstream/master' into TAJO-1109

commit c49a84af45fb6672feee1aa7be58431dcb64babc
Author: Jihun Kang <yk...@gmail.com>
Date:   2014-10-14T06:31:06Z

    Add hamcrest library for fine test on Catalog Server

commit 9496fcde7a2810c0e0575b0c5d483adac28f8bf3
Author: Jihun Kang <yk...@gmail.com>
Date:   2014-10-14T06:31:12Z

    Merge remote-tracking branch 'upstream/master' into TAJO-1109

commit c29099024bdce49cc5c65a172d1df3b12753882f
Author: Jihun Kang <yk...@gmail.com>
Date:   2014-10-14T10:14:09Z

    TAJO-1109: Separate SQL Statements from Catalog Stores

commit 3e7609287777780ba88d4726e3ef3d8548c030ab
Author: Jihun Kang <yk...@gmail.com>
Date:   2014-10-15T06:18:00Z

    TAJO-1109: Separate SQL Statements from Catalog Stores

commit 3559108bd2efcd8d32730dd3d2bea7cd845490c3
Author: Jihun Kang <yk...@gmail.com>
Date:   2014-10-15T06:31:27Z

    TAJO-1109: Separate SQL Statements from Catalog Stores

commit 2c895ea3253d58ffd43d3f4a70dbb093099c4888
Author: Jihun Kang <yk...@gmail.com>
Date:   2014-10-15T06:40:41Z

    TAJO-1109: Separate SQL Statements from Catalog Stores

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1109: Separate SQL Statements from Catalog...

Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:

    https://github.com/apache/tajo/pull/201#issuecomment-60554663
  
    Sure. No problems. I will update this patch with master branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1109: Separate SQL Statements from Catalog...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/201#issuecomment-60454535
  
    Hi @ykrips,
    
    Even though I'm not familiar with this approach, it definitely seems to make code cleaner as you mentioned in Jira. But, since I'm not familiar with it, I need more time to review it in more detail. It may take few days.
    
    Also, this patch seems to be stale gone. Could you rebase the patch?
    
    Thanks in advance


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1109: Separate SQL Statements from Catalog...

Posted by ykrips <gi...@git.apache.org>.
Github user ykrips commented on the pull request:

    https://github.com/apache/tajo/pull/201#issuecomment-60569702
  
    I'm sorry. I think that I need to figure out why my git repository works not correctly. I also close this pull request and re-open again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1109: Separate SQL Statements from Catalog...

Posted by ykrips <gi...@git.apache.org>.
Github user ykrips closed the pull request at:

    https://github.com/apache/tajo/pull/201


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---