You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@reef.apache.org by Andrew Chung <af...@gmail.com> on 2015/07/25 19:49:48 UTC

Final method parameters

Hi,

Would it be a good idea to add FinalParameters
<http://checkstyle.sourceforge.net/config_misc.html#FinalParameters> to our
checkstyle.xml? I can't think of a reason not to. I find myself often
forgetting to ensure that parameters are final while writing code. If this
sounds like a good idea, I'll open a JIRA for it.

Thanks,
Andrew

Re: Final method parameters

Posted by Yingda Chen <yd...@gmail.com>.

+1

On Sat, Jul 25, 2015 at 4:11 PM, Markus Weimer <ma...@weimo.de> wrote:

> +1
>
> On 2015-07-25 10:49, Andrew Chung wrote:
> > Hi,
> >
> > Would it be a good idea to add FinalParameters
> > <http://checkstyle.sourceforge.net/config_misc.html#FinalParameters> to
> our
> > checkstyle.xml? I can't think of a reason not to. I find myself often
> > forgetting to ensure that parameters are final while writing code. If
> this
> > sounds like a good idea, I'll open a JIRA for it.
> >
> > Thanks,
> > Andrew
> >
>

Re: Final method parameters

Posted by Markus Weimer <ma...@weimo.de>.

+1

On 2015-07-25 10:49, Andrew Chung wrote:
> Hi,
> 
> Would it be a good idea to add FinalParameters
> <http://checkstyle.sourceforge.net/config_misc.html#FinalParameters> to our
> checkstyle.xml? I can't think of a reason not to. I find myself often
> forgetting to ensure that parameters are final while writing code. If this
> sounds like a good idea, I'll open a JIRA for it.
> 
> Thanks,
> Andrew
>