[GitHub] [helix] pkuwm commented on a change in pull request #581: Fix NullPointerException for testCustomCodeRunner.

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #581: Fix NullPointerException for testCustomCodeRunner.
URL: https://github.com/apache/helix/pull/581#discussion_r345591532
 
 

 ##########
 File path: helix-core/src/test/java/org/apache/helix/integration/TestHelixCustomCodeRunner.java
 ##########
 @@ -127,7 +123,10 @@ public void testCustomCodeRunner() throws Exception {
     for (int i = 0; i < nodeNb; i++) {
       participants[i].syncStop();
     }
-    accessor.removeProperty(keyBuilder.liveInstance("newLiveInstance"));
+    HelixDataAccessor accessor =
+        new ZKHelixDataAccessor(_clusterName, new ZkBaseDataAccessor<>(_gZkClient));
+    Builder keyBuilder = accessor.keyBuilder();
+    accessor.removeProperty(keyBuilder.liveInstance("localhost_1000"));
 
 Review comment:
   Yes, instance configs are deleted in dropCluster().

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org