You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/11/05 18:30:02 UTC
[GitHub] [netbeans] BradWalker opened a new pull request #1616: Cleanup
fallthrough warnings
BradWalker opened a new pull request #1616: Cleanup fallthrough warnings
URL: https://github.com/apache/netbeans/pull/1616
There are numerous places in the code where the following warning is issued.
```
[repeat] /home/bwalker/src/netbeans/ide/css.editor/src/org/netbeans/modules/css/editor/csl/CssCompletion.java:718: warning: [fallthrough] possible fall-through into case
[repeat] case WS: //@import |
[repeat] ^
[repeat] /home/bwalker/src/netbeans/ide/css.editor/src/org/netbeans/modules/css/editor/csl/CssCompletion.java:824: warning: [fallthrough] possible fall-through into case
[repeat] default:
[repeat] ^
[repeat] /home/bwalker/src/netbeans/ide/css.editor/src/org/netbeans/modules/css/editor/csl/CssCompletion.java:1015: warning: [fallthrough] possible fall-through into case
[repeat] case mediaBody:
[repeat] ^
```
I've looked over each and every place where this warning is emitted. The vast majority of these warnings are due to lexer spaghetti. Which happens often when dealing w/ look-ahead parsers..
The simple fix is to add a "@SuppressWarnings("fallthrough")" to the method. as the code looks like the designer intended this behavior.
There is one place where I did find a bug..
_platform/core.network/src/org/netbeans/core/network/proxy/NetworkProxyReloader.java_
It's missing a break statement in this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists