You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/12/04 20:11:09 UTC
[PR] Add SQLite support [iceberg-python]
Fokko opened a new pull request, #178:
URL: https://github.com/apache/iceberg-python/pull/178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SQLite support [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #178:
URL: https://github.com/apache/iceberg-python/pull/178#issuecomment-1839491704
@jayceslesar Thanks for chiming in here! If I'm not mistaken, PyIceberg could serve as a backend behind the Ibis front end. We currently use sqlalchemy as an ORM for different database implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SQLite support [iceberg-python]
Posted by "bitsondatadev (via GitHub)" <gi...@apache.org>.
bitsondatadev commented on code in PR #178:
URL: https://github.com/apache/iceberg-python/pull/178#discussion_r1415369470
##########
tests/catalog/test_sql.py:
##########
@@ -21,6 +21,7 @@
import pytest
from pytest import TempPathFactory
+from pytest_lazyfixture import lazy_fixture
Review Comment:
Clever :)
##########
mkdocs/docs/configuration.md:
##########
@@ -150,6 +151,22 @@ catalog:
uri: postgresql+psycopg2://username:password@localhost/mydatabase
```
+In the case of SQLite:
+
+<!-- prettier-ignore-start -->
+
+!!! warning inline end "Development only"
+ SQLite is not built for concurrency, and should only be used for exploratory or development purposes.
Review Comment:
Avoid passive.
```suggestion
SQLite is not built for concurrency, you should use this catalog for exploratory or development purposes.
```
##########
mkdocs/docs/configuration.md:
##########
@@ -140,8 +140,9 @@ catalog:
## SQL Catalog
-The SQL catalog requires a database for its backend. As of now, pyiceberg only supports PostgreSQL through psycopg2.
-The database connection has to be configured using the `uri` property (see SQLAlchemy's [documentation for URL format](https://docs.sqlalchemy.org/en/20/core/engines.html#backend-specific-urls)):
+The SQL catalog requires a database for its backend. PyIceberg supports PostgreSQL and SQLite through psycopg2. The database connection has to be configured using the `uri` property (see SQLAlchemy's [documentation for URL format](https://docs.sqlalchemy.org/en/20/core/engines.html#backend-specific-urls)):
Review Comment:
```suggestion
The SQL catalog requires a database for its backend. PyIceberg supports PostgreSQL and SQLite through psycopg2. The database connection has to be configured using the `uri` property. See SQLAlchemy's [documentation for URL format](https://docs.sqlalchemy.org/en/20/core/engines.html#backend-specific-urls):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SQLite support [iceberg-python]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue merged PR #178:
URL: https://github.com/apache/iceberg-python/pull/178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SQLite support [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #178:
URL: https://github.com/apache/iceberg-python/pull/178#issuecomment-1841269395
Thanks for the suggestions @bitsondatadev 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Add SQLite support [iceberg-python]
Posted by "jayceslesar (via GitHub)" <gi...@apache.org>.
jayceslesar commented on PR #178:
URL: https://github.com/apache/iceberg-python/pull/178#issuecomment-1839457485
You might be able to support arbitrary SQL-like catalogs using https://github.com/ibis-project/ibis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org