You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/04/09 09:12:09 UTC
[GitHub] [mynewt-core] kasjer opened a new pull request #2557: mcu/nrf5340: Fix flash erase
kasjer opened a new pull request #2557:
URL: https://github.com/apache/mynewt-core/pull/2557
Flash erase was settings wrong value to CONFIG register so
erase procedure never started on both cores.
Now nrf5340_[net_]flash_erase_sector() is not sharing code with
write any more.
Additionally nrf5340_[net_]flash_erase() was added to that can
speed up erase a little bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer merged pull request #2557: mcu/nrf5340: Fix flash erase
Posted by GitBox <gi...@apache.org>.
kasjer merged pull request #2557:
URL: https://github.com/apache/mynewt-core/pull/2557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2557: mcu/nrf5340: Fix flash erase
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2557:
URL: https://github.com/apache/mynewt-core/pull/2557#issuecomment-816575457
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/mcu/nordic/nrf5340_net/src/hal_flash.c
<details>
```diff
@@ -144,7 +144,7 @@
static int
nrf5340_net_flash_erase(const struct hal_flash *dev, uint32_t address,
- uint32_t num_bytes)
+ uint32_t num_bytes)
{
uint32_t sector_address;
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2557: mcu/nrf5340: Fix flash erase
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2557:
URL: https://github.com/apache/mynewt-core/pull/2557#issuecomment-816586527
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2557: mcu/nrf5340: Fix flash erase
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2557:
URL: https://github.com/apache/mynewt-core/pull/2557#issuecomment-816575457
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/mcu/nordic/nrf5340_net/src/hal_flash.c
<details>
```diff
@@ -144,7 +144,7 @@
static int
nrf5340_net_flash_erase(const struct hal_flash *dev, uint32_t address,
- uint32_t num_bytes)
+ uint32_t num_bytes)
{
uint32_t sector_address;
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org