You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "jchen5 (via GitHub)" <gi...@apache.org> on 2023/07/17 14:40:55 UTC
[GitHub] [spark] jchen5 opened a new pull request, #42042: [SPARK-44448][SQL] Add test cases for DenseRankLimitIterator InferWindowGroupLimit bug
jchen5 opened a new pull request, #42042:
URL: https://github.com/apache/spark/pull/42042
### What changes were proposed in this pull request?
This PR adds test cases to demonstrate the bug described in https://issues.apache.org/jira/browse/SPARK-44448. PR for the fix is here: https://github.com/apache/spark/pull/42026
### Why are the changes needed?
Test cases for correctness bug.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Added tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #42042: [SPARK-44448][SQL] Add test cases for DenseRankLimitIterator InferWindowGroupLimit bug
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #42042:
URL: https://github.com/apache/spark/pull/42042#issuecomment-1640202719
@jchen5 You could close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jchen5 commented on pull request #42042: [SPARK-44448][SQL] Add test cases for DenseRankLimitIterator InferWindowGroupLimit bug
Posted by "jchen5 (via GitHub)" <gi...@apache.org>.
jchen5 commented on PR #42042:
URL: https://github.com/apache/spark/pull/42042#issuecomment-1639985725
This overlaps with https://github.com/apache/spark/pull/42026, we can just merge https://github.com/apache/spark/pull/42026 and close this one; or we can merge this and merge https://github.com/apache/spark/pull/42026 on top.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #42042: [SPARK-44448][SQL] Add test cases for DenseRankLimitIterator InferWindowGroupLimit bug
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #42042:
URL: https://github.com/apache/spark/pull/42042#issuecomment-1639284579
This PR is duplicated ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42042: [SPARK-44448][SQL] Add test cases for DenseRankLimitIterator InferWindowGroupLimit bug
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42042:
URL: https://github.com/apache/spark/pull/42042#issuecomment-1639913084
yeah, why do we use the same jira?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jchen5 closed pull request #42042: [SPARK-44448][SQL] Add test cases for DenseRankLimitIterator InferWindowGroupLimit bug
Posted by "jchen5 (via GitHub)" <gi...@apache.org>.
jchen5 closed pull request #42042: [SPARK-44448][SQL] Add test cases for DenseRankLimitIterator InferWindowGroupLimit bug
URL: https://github.com/apache/spark/pull/42042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jchen5 commented on pull request #42042: [SPARK-44448][SQL] Add test cases for DenseRankLimitIterator InferWindowGroupLimit bug
Posted by "jchen5 (via GitHub)" <gi...@apache.org>.
jchen5 commented on PR #42042:
URL: https://github.com/apache/spark/pull/42042#issuecomment-1640228713
Yes, let's just merge https://github.com/apache/spark/pull/42026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org