You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by "Xinyi Yan (Jira)" <ji...@apache.org> on 2020/05/06 17:10:00 UTC

[jira] [Commented] (PHOENIX-5339) Refactor IndexBuildManager and IndexBuilder to eliminate usage of Pair

    [ https://issues.apache.org/jira/browse/PHOENIX-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101012#comment-17101012 ] 

Xinyi Yan commented on PHOENIX-5339:
------------------------------------

Based on the above conversation, I don' think this is a blocker for 4.16 release too :) 

> Refactor IndexBuildManager and IndexBuilder to eliminate usage of Pair
> ----------------------------------------------------------------------
>
>                 Key: PHOENIX-5339
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5339
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Kadir OZDEMIR
>            Assignee: Gokcen Iskender
>            Priority: Major
>             Fix For: 4.15.1, 5.1.1, 4.16.1
>
>
> Some methods of the IndexBuildManager and IndexBuilder classes return a collection of pairs or triplets (implemented as pairs of pair and single). This makes the Indexer and especially IndexRegionObserver code difficult to read. We can replace the pair structures with a class, say IndexUpdate to make the code more readable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)