You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/12/19 07:08:31 UTC
[kudu-CR] clang-tidy: no warnings on structs with all public data members
Hello Alexey Serbin, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14930
to review the following change.
Change subject: clang-tidy: no warnings on structs with all public data members
......................................................................
clang-tidy: no warnings on structs with all public data members
Since the LLVM 9 upgrade clang-tidy has been warning on things like this:
src/kudu/tserver/tablet_copy_source_session.h:66:11: warning: member variable 'size' has public visibility [misc-non-private-member-variables-in-classes]
int64_t size;
^
'size' is indeed a public data member, but as per the Google Style Guide[1],
structs should consist of nothing but public data members.
I couldn't find a way to configure clang-tidy correctly on this issue, so
instead I reconfigured the corresponding check to not warn about any struct
or class where all data members are public. In the process, I rediscovered
our existing .clang-tidy configuration file and moved the recently disabled
checks there.
1. https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes
Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
---
M build-support/clang_tidy_gerrit.py
M src/kudu/.clang-tidy
2 files changed, 51 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/14930/1
--
To view, visit http://gerrit.cloudera.org:8080/14930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Gerrit-Change-Number: 14930
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] clang-tidy: no warnings on structs with all public data members
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14930/3/build-support/clang_tidy_gerrit.py
File build-support/clang_tidy_gerrit.py:
http://gerrit.cloudera.org:8080/#/c/14930/3/build-support/clang_tidy_gerrit.py@58
PS3, Line 58: # Note: this will incorporate any configuration from .clang-tidy.
readibility-magic-numbers warning was flagged on a recent gerrit review by Tidy bot. https://gerrit.cloudera.org/c/14934/
Are we sure the .clang-tidy config file is picked up the gerrit Tidy bot?
--
To view, visit http://gerrit.cloudera.org:8080/14930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Gerrit-Change-Number: 14930
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Dec 2019 00:13:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] clang-tidy: no warnings on structs with all public data members
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14930/2/src/kudu/.clang-tidy
File src/kudu/.clang-tidy:
http://gerrit.cloudera.org:8080/#/c/14930/2/src/kudu/.clang-tidy@54
PS2, Line 54: -readability-braces-around-statements
It was in the original version, but isn't it useful? Given the information at https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-string-init.html I think it is.
--
To view, visit http://gerrit.cloudera.org:8080/14930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Gerrit-Change-Number: 14930
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2019 21:13:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] clang-tidy: no warnings on structs with all public data members
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Gerrit-Change-Number: 14930
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2019 21:00:38 +0000
Gerrit-HasComments: No
[kudu-CR] clang-tidy: no warnings on structs with all public data members
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Gerrit-Change-Number: 14930
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2019 07:15:44 +0000
Gerrit-HasComments: No
[kudu-CR] clang-tidy: no warnings on structs with all public data members
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members
......................................................................
clang-tidy: no warnings on structs with all public data members
Since the LLVM 9 upgrade clang-tidy has been warning on things like this:
src/kudu/tserver/tablet_copy_source_session.h:66:11: warning: member variable 'size' has public visibility [misc-non-private-member-variables-in-classes]
int64_t size;
^
'size' is indeed a public data member, but as per the Google Style Guide[1],
structs should consist of nothing but public data members.
I couldn't find a way to configure clang-tidy correctly on this issue, so
instead I reconfigured the corresponding check to not warn about any struct
or class where all data members are public. In the process, I rediscovered
our existing .clang-tidy configuration file and moved the recently disabled
checks there.
1. https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes
Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Reviewed-on: http://gerrit.cloudera.org:8080/14930
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M build-support/clang_tidy_gerrit.py
M src/kudu/.clang-tidy
2 files changed, 51 insertions(+), 28 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Gerrit-Change-Number: 14930
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] clang-tidy: no warnings on structs with all public data members
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14930/2/src/kudu/.clang-tidy
File src/kudu/.clang-tidy:
http://gerrit.cloudera.org:8080/#/c/14930/2/src/kudu/.clang-tidy@54
PS2, Line 54: -readability-braces-around-statements
> I tend to agree, but I'd rather not increase the scope of this patch.
SGTM
--
To view, visit http://gerrit.cloudera.org:8080/14930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Gerrit-Change-Number: 14930
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2019 22:13:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] clang-tidy: no warnings on structs with all public data members
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members
......................................................................
Patch Set 3:
(1 comment)
> Patch Set 3:
>
> (1 comment)
I think the config file .clang-tidy needs to be in the base kudu directory to be picked up by clang_tidy_gerrit.py script when run.
http://gerrit.cloudera.org:8080/#/c/14930/3/build-support/clang_tidy_gerrit.py
File build-support/clang_tidy_gerrit.py:
http://gerrit.cloudera.org:8080/#/c/14930/3/build-support/clang_tidy_gerrit.py@58
PS3, Line 58: # Note: this will incorporate any configuration from .clang-tidy.
> readibility-magic-numbers warning was flagged on a recent gerrit review by
I think the config file .clang-tidy needs to be in the base kudu directory to be picked up by clang_tidy_gerrit.py script when run.
--
To view, visit http://gerrit.cloudera.org:8080/14930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Gerrit-Change-Number: 14930
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Dec 2019 00:25:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] clang-tidy: no warnings on structs with all public data members
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14930/2/src/kudu/.clang-tidy
File src/kudu/.clang-tidy:
http://gerrit.cloudera.org:8080/#/c/14930/2/src/kudu/.clang-tidy@54
PS2, Line 54: -readability-braces-around-statements
> It was in the original version, but isn't it useful? Given the information
I tend to agree, but I'd rather not increase the scope of this patch.
--
To view, visit http://gerrit.cloudera.org:8080/14930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Gerrit-Change-Number: 14930
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2019 22:03:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] clang-tidy: no warnings on structs with all public data members
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members
......................................................................
Patch Set 1: -Code-Review
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14930/1/src/kudu/.clang-tidy
File src/kudu/.clang-tidy:
http://gerrit.cloudera.org:8080/#/c/14930/1/src/kudu/.clang-tidy@25
PS1, Line 25: -
: google-readability-braces-around-statements,
nit: fix lines
http://gerrit.cloudera.org:8080/#/c/14930/1/src/kudu/.clang-tidy@27
PS1, Line 27: move
comma?
--
To view, visit http://gerrit.cloudera.org:8080/14930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Gerrit-Change-Number: 14930
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2019 07:18:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] clang-tidy: no warnings on structs with all public data members
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14930/1/src/kudu/.clang-tidy
File src/kudu/.clang-tidy:
http://gerrit.cloudera.org:8080/#/c/14930/1/src/kudu/.clang-tidy@25
PS1, Line 25: -
: google-readability-braces-around-statements,
> nit: fix lines
Whoops.
http://gerrit.cloudera.org:8080/#/c/14930/1/src/kudu/.clang-tidy@27
PS1, Line 27: move
> comma?
Yeah. Not sure how this worked.
--
To view, visit http://gerrit.cloudera.org:8080/14930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Gerrit-Change-Number: 14930
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 19 Dec 2019 07:38:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] clang-tidy: no warnings on structs with all public data members
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14930
to look at the new patch set (#2).
Change subject: clang-tidy: no warnings on structs with all public data members
......................................................................
clang-tidy: no warnings on structs with all public data members
Since the LLVM 9 upgrade clang-tidy has been warning on things like this:
src/kudu/tserver/tablet_copy_source_session.h:66:11: warning: member variable 'size' has public visibility [misc-non-private-member-variables-in-classes]
int64_t size;
^
'size' is indeed a public data member, but as per the Google Style Guide[1],
structs should consist of nothing but public data members.
I couldn't find a way to configure clang-tidy correctly on this issue, so
instead I reconfigured the corresponding check to not warn about any struct
or class where all data members are public. In the process, I rediscovered
our existing .clang-tidy configuration file and moved the recently disabled
checks there.
1. https://google.github.io/styleguide/cppguide.html#Structs_vs._Classes
Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
---
M build-support/clang_tidy_gerrit.py
M src/kudu/.clang-tidy
2 files changed, 51 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/14930/2
--
To view, visit http://gerrit.cloudera.org:8080/14930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Gerrit-Change-Number: 14930
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] clang-tidy: no warnings on structs with all public data members
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14930/3/build-support/clang_tidy_gerrit.py
File build-support/clang_tidy_gerrit.py:
http://gerrit.cloudera.org:8080/#/c/14930/3/build-support/clang_tidy_gerrit.py@58
PS3, Line 58: # Note: this will incorporate any configuration from .clang-tidy.
> I think the config file .clang-tidy needs to be in the base kudu directory
I don't think that's true. I played around with adding/removing that new option that justified this commit, and I saw clang-tidy warn/not-warn appropriately.
Also, the clang-tidy docs say that every parent directory from the source file all the way back to root is searched for .clang-tidy:
Configuration files:
clang-tidy attempts to read configuration for each source file from a
.clang-tidy file located in the closest parent directory of the source
file. If any configuration options have a corresponding command-line
option, command-line option takes precedence
https://clang.llvm.org/extra/clang-tidy/
--
To view, visit http://gerrit.cloudera.org:8080/14930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Gerrit-Change-Number: 14930
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Dec 2019 01:33:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] clang-tidy: no warnings on structs with all public data members
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14930 )
Change subject: clang-tidy: no warnings on structs with all public data members
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14930/3/build-support/clang_tidy_gerrit.py
File build-support/clang_tidy_gerrit.py:
http://gerrit.cloudera.org:8080/#/c/14930/3/build-support/clang_tidy_gerrit.py@58
PS3, Line 58: # Note: this will incorporate any configuration from .clang-tidy.
> I don't think that's true. I played around with adding/removing that new op
If I revert this change, then tidy bot doesn't complain about readibility-magic-numbers check on FastHash change locally https://gerrit.cloudera.org/c/14934/ .
Let me try to figure what's going wrong...
--
To view, visit http://gerrit.cloudera.org:8080/14930
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9913fd0b0410b44cf36f044256ef0266949d95
Gerrit-Change-Number: 14930
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 20 Dec 2019 18:16:24 +0000
Gerrit-HasComments: Yes