You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by resmo <gi...@git.apache.org> on 2015/03/04 13:27:58 UTC

[GitHub] cloudstack pull request: CreatePortForwardingRuleCmd: Fix typo in ...

GitHub user resmo opened a pull request:

    https://github.com/apache/cloudstack/pull/94

    CreatePortForwardingRuleCmd: Fix typo in description

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/resmo/cloudstack patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/94.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #94
    
----
commit 7028541210fc427f3b293d2dbf85324a811098ea
Author: René Moser <ma...@renemoser.net>
Date:   2015-03-04T12:27:29Z

    CreatePortForwardingRuleCmd: Fix typo in doc

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CreatePortForwardingRuleCmd: Fix typo in ...

Posted by runseb <gi...@git.apache.org>.

Github user runseb commented on the pull request:

    https://github.com/apache/cloudstack/pull/94#issuecomment-77337309
  
    thanks for the patch, keep them coming


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CreatePortForwardingRuleCmd: Fix typo in ...

Posted by resmo <gi...@git.apache.org>.

Github user resmo commented on the pull request:

    https://github.com/apache/cloudstack/pull/94#issuecomment-77149699
  
    @runseb ah yes, sure!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CreatePortForwardingRuleCmd: Fix typo in ...

Posted by resmo <gi...@git.apache.org>.

Github user resmo commented on the pull request:

    https://github.com/apache/cloudstack/pull/94#issuecomment-77151592
  
    Did some more text stylings. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CreatePortForwardingRuleCmd: Fix typo in ...

Posted by runseb <gi...@git.apache.org>.

Github user runseb commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/94#discussion_r25770875
  
    --- Diff: api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java ---
    @@ -111,7 +111,7 @@
         @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST, collectionType = CommandType.STRING, description = "the cidr list to forward traffic from")
         private List<String> cidrlist;
     
    -    @Parameter(name = ApiConstants.OPEN_FIREWALL, type = CommandType.BOOLEAN, description = "if true, firewall rule for source/end pubic port is automatically created; "
    +    @Parameter(name = ApiConstants.OPEN_FIREWALL, type = CommandType.BOOLEAN, description = "if true, firewall rule for source/end public port is automatically created; "
             + "if false - firewall rule has to be created explicitely. If not specified 1) defaulted to false when PF"
    --- End diff --
    
    actually, there is another one here 'explicitly' can you patch and squash ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CreatePortForwardingRuleCmd: Fix typo in ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/94


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---