You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by skitt <gi...@git.apache.org> on 2015/09/01 21:16:56 UTC
[GitHub] maven pull request: Support directories with spaces in mvn
GitHub user skitt opened a pull request:
https://github.com/apache/maven/pull/63
Support directories with spaces in mvn
find_maven_basedir() doesn't handle a current working directory containing spaces; this patch fixes this behaviour.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/skitt/maven patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/63.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #63
----
commit 683745adc1645e4d91c622c001a6699370dc8b14
Author: Stephen Kitt <st...@sk2.org>
Date: 2015-09-01T19:16:47Z
Support directories with spaces in mvn
find_maven_basedir() doesn't handle a current working directory containing spaces; this patch fixes this behaviour.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Support directories with spaces in mvn
Posted by skitt <gi...@git.apache.org>.
Github user skitt commented on the pull request:
https://github.com/apache/maven/pull/63#issuecomment-138080313
This has been merged, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Support directories with spaces in mvn
Posted by skitt <gi...@git.apache.org>.
Github user skitt commented on the pull request:
https://github.com/apache/maven/pull/63#issuecomment-137209331
I've filed https://issues.apache.org/jira/browse/MNG-5884.
I don't have a Windows installation to test it, but I don't see any particular whitespace handling for MAVEN_PROJECTBASEDIR in mvn.cmd so it might well be affected too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Support directories with spaces in mvn
Posted by skitt <gi...@git.apache.org>.
Github user skitt closed the pull request at:
https://github.com/apache/maven/pull/63
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request: Support directories with spaces in mvn
Posted by michael-o <gi...@git.apache.org>.
Github user michael-o commented on the pull request:
https://github.com/apache/maven/pull/63#issuecomment-136840652
Does this apply to Windows too?
Can you please open a JIRA issue for that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org