You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/03/24 22:06:25 UTC
zeppelin git commit: [ZEPPELIN-1889] [FIX] Multiple groups in chart
doesn't work
Repository: zeppelin
Updated Branches:
refs/heads/master 58189ec89 -> 829cabb70
[ZEPPELIN-1889] [FIX] Multiple groups in chart doesn't work
### What is this PR for?
Fix for multiple group in multi-bar chart
If any value is missing under any domain key in stacked multi-bar chart,
it won't get rendered. Fix this bug by adding `fillMissingValues` flag in
`d3DataFromPivot()`
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-1889](https://issues.apache.org/jira/browse/ZEPPELIN-1889)
### How should this be tested?
* Create a paragraph with tabular output
* Add multiple groups to input
* Render the stacked multi bar chart
* Chart should be rendered properly
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: ess_ess <sr...@gmail.com>
Closes #2168 from sravan-s/ZEPPELIN-1889-multiple-groups and squashes the following commits:
d4cc5de [ess_ess] Fill missing values to grouped data
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/829cabb7
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/829cabb7
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/829cabb7
Branch: refs/heads/master
Commit: 829cabb70c418c7ca26aad7a08929dbd8e7e4f86
Parents: 58189ec
Author: ess_ess <sr...@gmail.com>
Authored: Sun Mar 19 21:22:06 2017 +0530
Committer: Lee moon soo <mo...@apache.org>
Committed: Fri Mar 24 15:06:21 2017 -0700
----------------------------------------------------------------------
.../src/app/visualization/builtins/visualization-barchart.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/829cabb7/zeppelin-web/src/app/visualization/builtins/visualization-barchart.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/visualization/builtins/visualization-barchart.js b/zeppelin-web/src/app/visualization/builtins/visualization-barchart.js
index a0ac573..ffc0c22 100644
--- a/zeppelin-web/src/app/visualization/builtins/visualization-barchart.js
+++ b/zeppelin-web/src/app/visualization/builtins/visualization-barchart.js
@@ -41,7 +41,7 @@ export default class BarchartVisualization extends Nvd3ChartVisualization {
pivot.groups,
pivot.values,
true,
- false,
+ true,
true);
super.render(d3Data);