You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Danny Cranmer (Jira)" <ji...@apache.org> on 2022/11/23 13:47:00 UTC

[jira] [Commented] (FLINK-29906) Address tabs/spaces in checkstyle/spotless

    [ https://issues.apache.org/jira/browse/FLINK-29906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637756#comment-17637756 ] 

Danny Cranmer commented on FLINK-29906:
---------------------------------------

Merged commit [{{170947e}}|https://github.com/apache/flink-connector-aws/commit/170947e9a83e641a0a8ba0d584f800d058571d1c] into apache:main 

> Address tabs/spaces in checkstyle/spotless
> ------------------------------------------
>
>                 Key: FLINK-29906
>                 URL: https://issues.apache.org/jira/browse/FLINK-29906
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / AWS
>            Reporter: Danny Cranmer
>            Assignee: Daren Wong
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: aws-connector-2.0.0
>
>
> The DynamoDB connector has a mix of tabs and spaces, the quality config does not seem to be enforcing anything. The code style guide says we should [use spaces|https://flink.apache.org/contributing/code-style-and-quality-formatting.html#whitespaces].
> - Update code to use spaces
> - Fix quality plugin to reject tabs



--
This message was sent by Atlassian Jira
(v8.20.10#820010)