You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/12 20:51:23 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5473: arch/sim: Always typedef xcpt_reg_t to unsigned long
xiaoxiang781216 opened a new pull request #5473:
URL: https://github.com/apache/incubator-nuttx/pull/5473
## Summary
to simplify the code logic. See discussion here: https://github.com/apache/incubator-nuttx/pull/5382
## Impact
No, code refactor
## Testing
sim:smp and sim:ostest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5473: arch/sim: Always typedef xcpt_reg_t to unsigned long
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5473:
URL: https://github.com/apache/incubator-nuttx/pull/5473#discussion_r806139302
##########
File path: arch/sim/src/sim/up_vfork.c
##########
@@ -93,8 +93,8 @@ pid_t up_vfork(const xcpt_reg_t *context)
xcpt_reg_t stackutil;
sinfo("vfork context [%p]:\n", context);
- sinfo(" frame pointer:%08" PRIxPTR " sp:%08" PRIxPTR " pc:%08" PRIxPTR ""
- "\n", context[JB_FP], context[JB_SP], context[JB_PC]);
+ sinfo(" frame pointer:%08lx sp:%08lx pc:%08lx\n",
Review comment:
Should it be `%08` always or `%08` vs `%16` depending on x86 vs x86_64?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5473: arch/sim: Always typedef xcpt_reg_t to unsigned long
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5473:
URL: https://github.com/apache/incubator-nuttx/pull/5473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5473: arch/sim: Always typedef xcpt_reg_t to unsigned long
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5473:
URL: https://github.com/apache/incubator-nuttx/pull/5473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5473: arch/sim: Always typedef xcpt_reg_t to unsigned long
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5473:
URL: https://github.com/apache/incubator-nuttx/pull/5473#discussion_r806427648
##########
File path: arch/sim/src/sim/up_vfork.c
##########
@@ -93,8 +93,8 @@ pid_t up_vfork(const xcpt_reg_t *context)
xcpt_reg_t stackutil;
sinfo("vfork context [%p]:\n", context);
- sinfo(" frame pointer:%08" PRIxPTR " sp:%08" PRIxPTR " pc:%08" PRIxPTR ""
- "\n", context[JB_FP], context[JB_SP], context[JB_PC]);
+ sinfo(" frame pointer:%08lx sp:%08lx pc:%08lx\n",
Review comment:
I take a simple approach: remove 08 directly since the alignment isn't critical here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5473: arch/sim: Always typedef xcpt_reg_t to unsigned long
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5473:
URL: https://github.com/apache/incubator-nuttx/pull/5473#discussion_r806139302
##########
File path: arch/sim/src/sim/up_vfork.c
##########
@@ -93,8 +93,8 @@ pid_t up_vfork(const xcpt_reg_t *context)
xcpt_reg_t stackutil;
sinfo("vfork context [%p]:\n", context);
- sinfo(" frame pointer:%08" PRIxPTR " sp:%08" PRIxPTR " pc:%08" PRIxPTR ""
- "\n", context[JB_FP], context[JB_SP], context[JB_PC]);
+ sinfo(" frame pointer:%08lx sp:%08lx pc:%08lx\n",
Review comment:
Should it be `%08` always or `%08` vs `%16` depending on x86 vs x86_64?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org