[GitHub] [spark] viirya commented on a diff in pull request #36491: [SPARK-39134][SS] Add custom metric of skipped null values for stream join operator

[GitBox <gi...@apache.org>]

viirya commented on code in PR #36491:
URL: https://github.com/apache/spark/pull/36491#discussion_r869697721


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala:
##########
@@ -617,6 +619,7 @@ class SymmetricHashJoinStateManager(
             val keyWithIndex = keyWithIndexRow(key, index)
             val valuePair = valueRowConverter.convertValue(stateStore.get(keyWithIndex))
             if (valuePair == null && storeConf.skipNullsForStreamStreamJoins) {
+              skippedNullValueCount.map(_ += 1L)

Review Comment:
   I was added it in early commit, but removed it as that is for removing old states. I think the interest is to know how many times null values are happened during joining.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org