[GitHub] [solr] cpoerschke commented on pull request #159: [SOLR-10059] Handle appends params in distributed requests

[GitBox <gi...@apache.org>]

cpoerschke commented on pull request #159:
URL: https://github.com/apache/solr/pull/159#issuecomment-969144721


   > @cpoerschke I wanted to get this sorted, any chance you could be another set of eyes????
   
   From looking at the changes I'm wondering if [RequestUtil](https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.11.0/solr/core/src/java/org/apache/solr/request/json/RequestUtil.java#L51-L52) might be an alternative place for the logic since the _"don't expand macros on the shard"_ logic already happens there.
   
   From reading about the context of the changes on https://issues.apache.org/jira/browse/SOLR-10059 on 2017-03-01 there's a mention of multi-collection requests, I don't yet fully understand how that fits into the bigger picture.
   
   From running the new tests locally, hmm, they don't pass here at the moment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org