You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Küng <to...@gmail.com> on 2005/10/19 17:31:55 UTC
[PATCH] fix broken svn_wc_dup_status2()
Hi,
Was just trying to make good use of the new ood_* params in the
svn_wc_status2_t struct when I discovered a bug in svn_wc_dup_status2:
the ood_last_commit_author isn't copied! When I checked the source, I
also found that the url isn't copied either (which btw might explain
some crashreports I received for TSVN but never could really find the
reason/location).
So here's a patch to fix this.
I'd also recommend to backport this to 1.3.x (and if I'm not mistaken,
this also partly applies to 1.2.x - the url wasn't copied in those
versions either).
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.tigris.org
Re: [PATCH] fix broken svn_wc_dup_status2()
Posted by Stefan Küng <to...@gmail.com>.
Garrett Rooney wrote:
> Good catch, committed in revision 16829.
Thanks!
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] fix broken svn_wc_dup_status2()
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 10/19/05, Stefan Küng <to...@gmail.com> wrote:
> Hi,
>
> Was just trying to make good use of the new ood_* params in the
> svn_wc_status2_t struct when I discovered a bug in svn_wc_dup_status2:
> the ood_last_commit_author isn't copied! When I checked the source, I
> also found that the url isn't copied either (which btw might explain
> some crashreports I received for TSVN but never could really find the
> reason/location).
>
> So here's a patch to fix this.
Good catch, committed in revision 16829.
> I'd also recommend to backport this to 1.3.x (and if I'm not mistaken,
> this also partly applies to 1.2.x - the url wasn't copied in those
> versions either).
I'll nominate it for backport to 1.3.x right now.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org