You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "yashmayya (via GitHub)" <gi...@apache.org> on 2023/02/03 07:52:03 UTC
[GitHub] [kafka] yashmayya opened a new pull request, #13194: MINOR: Update incorrect / misleading comment regarding rebalance exceptions in WorkerSinkTask
yashmayya opened a new pull request, #13194:
URL: https://github.com/apache/kafka/pull/13194
- Handling of consumer rebalance related failures in sink tasks was added in https://github.com/apache/kafka/pull/767
- Exceptions thrown in the consumer rebalance listener are swallowed by the consumer; so the `WorkerSinkTask` stores exceptions arising from handling of assigned / revoked partitions and re-throws it in `WorkerSinkTask::pollConsumer` after the consumer poll returns.
- This exception is propagated up from `WorkerSinkTask::pollConsumer` <- `WorkerSinkTask::poll` <- `WorkerSinkTask::iteration` <- `WorkerSinkTask::execute` <- `WorkerTask::doRun` <- `WorkerTask::run` where it is finally handled by marking the task as failed - https://github.com/apache/kafka/blob/b8e606355b71528aa438e80ffeb3042d0d586998/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerTask.java#L259-L260
- Hence, the comment `Exceptions raised from the task during a rebalance should be rethrown to stop the worker` is inaccurate (the *worker* itself isn't stopped, the task is) and is being reworded.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante merged pull request #13194: MINOR: Update incorrect / misleading comment regarding rebalance exceptions in WorkerSinkTask
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante merged PR #13194:
URL: https://github.com/apache/kafka/pull/13194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] yashmayya commented on pull request #13194: MINOR: Update incorrect / misleading comment regarding rebalance exceptions in WorkerSinkTask
Posted by "yashmayya (via GitHub)" <gi...@apache.org>.
yashmayya commented on PR #13194:
URL: https://github.com/apache/kafka/pull/13194#issuecomment-1415265813
Hey @C0urante, could you please take a look at this one-liner comment update whenever you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org