[GitHub] [pinot] navina commented on a diff in pull request #9071: Add support for IAM role based credentials in Kinesis Plugin

[GitBox <gi...@apache.org>]

navina commented on code in PR #9071:
URL: https://github.com/apache/pinot/pull/9071#discussion_r925051832


##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConfig.java:
##########
@@ -48,6 +61,14 @@ public class KinesisConfig {
   private final String _secretKey;
   private final String _endpoint;
 
+  // IAM Role values
+  private boolean _iamRoleBasedAccess;

Review Comment:
   can you add some javadoc on what these configs mean and which ones are optional ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org