You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-cvs@httpd.apache.org by je...@apache.org on 2003/01/29 07:19:20 UTC
cvs commit: httpd-test/flood CHANGES flood_socket_keepalive.c
jerenkrantz 2003/01/28 22:19:20
Modified: flood CHANGES flood_socket_keepalive.c
Log:
(Win32) Fixed link error apr_pstrmemdup in flood_socket_keepalive.c.
This patch addresses a link error. The code invoked apr_pstrmemdup()
in flood_socket_keepalive.c without including the proper declaration.
The compiler generates its own guess, which is incorrect. The code now
includes the file:
apr_strings.h
so that it picks up the proper declaration of apr_pstrmemdup.
Below are examples of the compile-time warning and the
link failures that this patch addresses.
flood_socket_keepalive.c(407) : warning C4013: 'apr_pstrmemdup'
undefined; assuming extern returning int
flood_socket_keepalive.obj : error LNK2001: unresolved external
symbol _apr_pstrmemdup
Submitted by: Phi-Long Tran <pt...@pobox.com>
Reviewed by: Justin Erenkrantz
Revision Changes Path
1.45 +3 -0 httpd-test/flood/CHANGES
Index: CHANGES
===================================================================
RCS file: /home/cvs/httpd-test/flood/CHANGES,v
retrieving revision 1.44
retrieving revision 1.45
diff -u -u -r1.44 -r1.45
--- CHANGES 29 Jan 2003 06:16:59 -0000 1.44
+++ CHANGES 29 Jan 2003 06:19:20 -0000 1.45
@@ -1,5 +1,8 @@
Changes since 1.0:
+* Include correct header to import defintion of apr_pstrmemdup in
+ flood_socket_keepalive.c. [Phi-Long Tran <pt...@pobox.com>]
+
* Namespace protect expand_param_e enum values to not conflict with Win32
headers. [Phi-Long Tran <pt...@pobox.com>]
1.16 +1 -0 httpd-test/flood/flood_socket_keepalive.c
Index: flood_socket_keepalive.c
===================================================================
RCS file: /home/cvs/httpd-test/flood/flood_socket_keepalive.c,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -u -r1.15 -r1.16
--- flood_socket_keepalive.c 22 Jul 2002 05:50:05 -0000 1.15
+++ flood_socket_keepalive.c 29 Jan 2003 06:19:20 -0000 1.16
@@ -53,6 +53,7 @@
*/
#include <apr.h>
+#include <apr_strings.h>
#if APR_HAVE_STDLIB_H
#include <stdlib.h> /* rand/strtol */