[GitHub] [geode] jinmeiliao opened pull request #4083: GEODE-6897: revert accidental change of apidoc's link for dev rest api.

["jinmeiliao (GitHub)" <gi...@apache.org>]

we should not change the api docs link for dev rest api.

[ Full content available at: https://github.com/apache/geode/pull/4083 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao closed pull request #4083: GEODE-6897: revert accidental change of apidoc's link for dev rest api.

["jinmeiliao (GitHub)" <gi...@apache.org>]

[ pull request closed by jinmeiliao ]

[ Full content available at: https://github.com/apache/geode/pull/4083 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #4083: GEODE-6897: revert accidental change of apidoc's link for dev rest api.

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

Does this need to be versioned? Should it be more like the "docs" one and just be "/api-docs/**"?

[ Full content available at: https://github.com/apache/geode/pull/4083 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] onichols-pivotal commented on issue #4083: GEODE-6897: revert accidental change of apidoc's link for dev rest api.

["onichols-pivotal (GitHub)" <gi...@apache.org>]

What happens when we go to v3?  If this is not supposed to be a versioned link, how is v2 any better?

[ Full content available at: https://github.com/apache/geode/pull/4083 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on issue #4083: GEODE-6897: revert accidental change of apidoc's link for dev rest api.

["jinmeiliao (GitHub)" <gi...@apache.org>]

In fact, since dev rest is always under /geode/v1, I prefer to have the dev rest api also be under /geode/v1/api-docs, instead of geode/v2/api-docs. The original swagger api docs for dev rest is in fact under /geode/v1/api-docs, but when Kevin upgraded swagger to use the version 2 of api-docs, he accidentally changed v1 to v2. If we want to roll back to what it was before all the mis-haps, the dev rest api-docs link should remain as "/geode/v1/api-docs"

[ Full content available at: https://github.com/apache/geode/pull/4083 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on issue #4083: GEODE-6897: revert accidental change of apidoc's link for dev rest api.

["jinmeiliao (GitHub)" <gi...@apache.org>]

@jmelchio 

[ Full content available at: https://github.com/apache/geode/pull/4083 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #4083: GEODE-6897: revert accidental change of apidoc's link for dev rest api.

["jinmeiliao (GitHub)" <gi...@apache.org>]

because swagger library is updated, our swagger version is v2.

[ Full content available at: https://github.com/apache/geode/pull/4083 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #4083: GEODE-6897: revert accidental change of apidoc's link for dev rest api.

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

Why is the variable name still "v2" since the value has been changed to "v1"?

[ Full content available at: https://github.com/apache/geode/pull/4083 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] onichols-pivotal commented on issue #4083: GEODE-6897: revert accidental change of apidoc's link for dev rest api.

["onichols-pivotal (GitHub)" <gi...@apache.org>]

Does this change need to go into 1.10 as well?

[ Full content available at: https://github.com/apache/geode/pull/4083 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org