You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/08/10 09:06:02 UTC

Review Request 37281: Maintenance Primitives: Added Unavailability to Offer in V1 API.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37281/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
    https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
-------

See summary.


Diffs
-----

  include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 

Diff: https://reviews.apache.org/r/37281/diff/


Testing
-------


Thanks,

Joris Van Remoortere


Re: Review Request 37281: Maintenance Primitives: Added Unavailability to Offer in V1 API.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37281/#review96381
-----------------------------------------------------------


I think that this can be abandoned, as https://reviews.apache.org/r/36321/diff/11#0 is already covering this part and also the time is using TimeSpec to be more accurate.

- Guangya Liu


On Aug. 25, 2015, 2:13 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37281/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 2:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/37281/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Re: Review Request 37281: Maintenance Primitives: Added Unavailability to Offer in V1 API.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37281/
-----------------------------------------------------------

(Updated Aug. 25, 2015, 10:48 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
    https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
-------

See summary.


Diffs
-----

  include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 

Diff: https://reviews.apache.org/r/37281/diff/


Testing
-------


Thanks,

Joris Van Remoortere


Re: Review Request 37281: Maintenance Primitives: Added Unavailability to Offer in V1 API.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37281/
-----------------------------------------------------------

(Updated Aug. 25, 2015, 2:13 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Changes
-------

Rebased.


Bugs: MESOS-1474
    https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 

Diff: https://reviews.apache.org/r/37281/diff/


Testing
-------


Thanks,

Joris Van Remoortere


Re: Review Request 37281: Maintenance Primitives: Added Unavailability to Offer in V1 API.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37281/
-----------------------------------------------------------

(Updated Aug. 18, 2015, 6:57 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Changes
-------

Rebased.


Bugs: MESOS-1474
    https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 

Diff: https://reviews.apache.org/r/37281/diff/


Testing
-------


Thanks,

Joris Van Remoortere


Re: Review Request 37281: Maintenance Primitives: Added Unavailability to Offer in V1 API.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37281/#review95177
-----------------------------------------------------------

Ship it!


Ship It!

- Joseph Wu


On Aug. 10, 2015, 12:06 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37281/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 12:06 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321 
> 
> Diff: https://reviews.apache.org/r/37281/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>