You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "guan404ming (via GitHub)" <gi...@apache.org> on 2025/08/10 15:06:04 UTC
[PR] Refactor HITL details fetching to use exact dagId and taskId [airflow]
guan404ming opened a new pull request, #54319:
URL: https://github.com/apache/airflow/pull/54319
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
## Why
- client-side filtering logic duplicated across multiple components
- inconsistent parameter usage between different pages
## How
- replace `dagIdPattern` with `dagId` for exact dag matching across all components
- removed client-side filtering
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor HITL details fetching to use exact dagId and taskId [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #54319:
URL: https://github.com/apache/airflow/pull/54319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor HITL details fetching to use exact dagId and taskId [airflow]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on code in PR #54319:
URL: https://github.com/apache/airflow/pull/54319#discussion_r2272350321
##########
airflow-core/src/airflow/ui/src/pages/HITLTaskInstances/HITLTaskInstances.tsx:
##########
@@ -133,9 +133,11 @@ export const HITLTaskInstances = () => {
const { data, error, isLoading } = useHumanInTheLoopServiceGetHitlDetails(
{
- dagIdPattern: dagId,
+ dagId,
dagRunId: runId,
responseReceived: Boolean(responseReceived) ? responseReceived === "true" : undefined,
+ taskId: Boolean(groupId) ? undefined : taskId,
+ taskIdPattern: groupId,
Review Comment:
> As mentioned in the other PR this is a wrong way of filtering 'per group id' and I think we should remove that altogether for now until we update the backend.
I agree. I’ve reviewed the example and yes using a pattern to filter TI for a group does cause issues. Let’s remove it until we update the backend.
> Also 'Action Required' are not yet supported for group, I'm not sure why we have group code path here?
We initially intended to support groups and used the pattern for filtering, which is why the group code path exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Refactor HITL details fetching to use exact dagId and taskId [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #54319:
URL: https://github.com/apache/airflow/pull/54319#discussion_r2270315767
##########
airflow-core/src/airflow/ui/src/pages/HITLTaskInstances/HITLTaskInstances.tsx:
##########
@@ -133,9 +133,11 @@ export const HITLTaskInstances = () => {
const { data, error, isLoading } = useHumanInTheLoopServiceGetHitlDetails(
{
- dagIdPattern: dagId,
+ dagId,
dagRunId: runId,
responseReceived: Boolean(responseReceived) ? responseReceived === "true" : undefined,
+ taskId: Boolean(groupId) ? undefined : taskId,
+ taskIdPattern: groupId,
Review Comment:
Since this is not related to this PR, we can merge, and remove such code in a follow up PR.
##########
airflow-core/src/airflow/ui/src/pages/HITLTaskInstances/HITLTaskInstances.tsx:
##########
@@ -133,9 +133,11 @@ export const HITLTaskInstances = () => {
const { data, error, isLoading } = useHumanInTheLoopServiceGetHitlDetails(
{
- dagIdPattern: dagId,
+ dagId,
dagRunId: runId,
responseReceived: Boolean(responseReceived) ? responseReceived === "true" : undefined,
+ taskId: Boolean(groupId) ? undefined : taskId,
+ taskIdPattern: groupId,
Review Comment:
Why do we do special treatment for group there?
As mentioned in the other PR this is a wrong way of filtering 'per group id' and I think we should remove that altogether for now until we update the backend.
Also 'Action Required' are not yet supported for group, I'm not sure why we have group code path here?
##########
airflow-core/src/airflow/ui/src/pages/HITLTaskInstances/HITLTaskInstances.tsx:
##########
@@ -133,9 +133,11 @@ export const HITLTaskInstances = () => {
const { data, error, isLoading } = useHumanInTheLoopServiceGetHitlDetails(
{
- dagIdPattern: dagId,
+ dagId,
dagRunId: runId,
responseReceived: Boolean(responseReceived) ? responseReceived === "true" : undefined,
+ taskId: Boolean(groupId) ? undefined : taskId,
+ taskIdPattern: groupId,
Review Comment:
cc: @guan404ming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org