You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by "Antoine Pitrou (Jira)" <ji...@apache.org> on 2021/03/31 14:20:00 UTC

[jira] [Commented] (PARQUET-1991) Reserve ConvertedType==24 due to bug in parquet-cpp implementation

    [ https://issues.apache.org/jira/browse/PARQUET-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312411#comment-17312411 ] 

Antoine Pitrou commented on PARQUET-1991:
-----------------------------------------

Context:

https://github.com/apache/parquet-format/pull/45 added a converted type named "NA" in the Thrift definition.
https://github.com/apache/parquet-cpp/pull/360 added a converted type named "NA" in order to serialize Arrow null arrays.
https://github.com/apache/parquet-format/pull/51 then removed the converted type "NA" (before it was released) and replaced it with the logical type "NullType". But the Parquet C++ implementation wasn't updated to also remove "NA".


> Reserve ConvertedType==24 due to bug in parquet-cpp implementation
> ------------------------------------------------------------------
>
>                 Key: PARQUET-1991
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1991
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-format
>            Reporter: Micah Kornfield
>            Priority: Major
>
> https://issues.apache.org/jira/browse/PARQUET-1990 sometimes a converted type of 24 is written out because we are leaking a C++ enum value that doesn't exist in the parquet thrift specification.  We should reserve this so if any other converted type elements are added future readers of older files don't accidentally misinterpret this value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)