You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "adityashirsatrao007 (via GitHub)" <gi...@apache.org> on 2025/12/07 17:12:14 UTC
[PR] fix: Set correct nullability for luhn_check (#19177) [datafusion]
adityashirsatrao007 opened a new pull request, #19181:
URL: https://github.com/apache/datafusion/pull/19181
Closes #19177
## Changes
- Implemented eturn_field_from_args for SparkLuhnCheck.
- Nullability is now determined dynamically based on input arguments, rather than defaulting to true.
## Verification
- Logic ensures that output is nullable only if the input is nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Set correct nullability for luhn_check (#19177) [datafusion]
Posted by "rluvaton (via GitHub)" <gi...@apache.org>.
rluvaton commented on PR #19181:
URL: https://github.com/apache/datafusion/pull/19181#issuecomment-3622751816
Thank you for the PR, but it seems like I was wrong opening that specific issue and spark declare that as always nullable true:
https://github.com/apache/datafusion/issues/19177#issuecomment-3622747162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Set correct nullability for luhn_check (#19177) [datafusion]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #19181:
URL: https://github.com/apache/datafusion/pull/19181#discussion_r2596454067
##########
datafusion/spark/src/function/string/luhn_check.rs:
##########
@@ -15,16 +15,14 @@
// specific language governing permissions and limitations
// under the License.
-use std::{any::Any, sync::Arc};
-
use arrow::array::{Array, AsArray, BooleanArray};
-use arrow::datatypes::DataType;
+use arrow::datatypes::{DataType, Field, FieldRef};
use arrow::datatypes::DataType::Boolean;
use datafusion_common::utils::take_function_args;
use datafusion_common::{exec_err, Result, ScalarValue};
use datafusion_expr::{
- ColumnarValue, ScalarFunctionArgs, ScalarUDFImpl, Signature, TypeSignature,
- Volatility,
+ ColumnarValue, ReturnFieldArgs, ScalarFunctionArgs, ScalarUDFImpl, Signature,
+ TypeSignature, Volatility,
};
Review Comment:
Missing required imports for `Arc` and `Any`. The code uses `Arc::new()` on line 75 and `&dyn Any` on line 57, but `std::sync::Arc` and `std::any::Any` are not imported. These imports were removed but are still needed by the code.
```suggestion
use std::sync::Arc;
use std::any::Any;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Set correct nullability for luhn_check (#19177) [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey closed pull request #19181: fix: Set correct nullability for luhn_check (#19177)
URL: https://github.com/apache/datafusion/pull/19181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org